Skip to content

Catch negative labels in sequences #637

@mcgrathcm

Description

@mcgrathcm

Feature Request

Hi Devs,

I am working with some 4DFlow sequences, and am using labels for ky,kz and cardiac phase/encoding.
I accidentally included negative labels for ky,kz while debugging, and this results in a crash after simulation as the ISMRMRD format uses uint16.

In this case it was not too much of a problem, as the simulation was only a few minutes long, but this could be annoying for users who want to perform very long simulations, as it happens after the simulation.

It would be great if simulate() checked the sequence for negative labels at the start, and threw an error prior to any significant computation being done. Additionally, maybe it would be useful if read_seq() also gave a warning when importing a sequence with negative labels.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions