Skip to content

Add button in KomaUI to reload sequence#790

Merged
cncastillo merged 4 commits into
JuliaHealth:masterfrom
mcgrathcm:KomaUI-reload-seq
May 25, 2026
Merged

Add button in KomaUI to reload sequence#790
cncastillo merged 4 commits into
JuliaHealth:masterfrom
mcgrathcm:KomaUI-reload-seq

Conversation

@mcgrathcm
Copy link
Copy Markdown
Contributor

Currently in KomaUI, if the underlying .seq file is changed, it is only possible to reload the sequence by first loading a different sequence, then loading the one you want.
This just adds a button to the left of the sequence picker to allow the user to reload the sequence.
Very useful when coupled with the sequence generation functionality in Koma.

@mcgrathcm mcgrathcm requested a review from cncastillo as a code owner May 24, 2026 19:57
@cncastillo
Copy link
Copy Markdown
Member

That is cool! do you have a preview?

@mcgrathcm
Copy link
Copy Markdown
Contributor Author

Currently on the left side. Could also move it to the left of the sequence name.

image

@cncastillo
Copy link
Copy Markdown
Member

I also tried it to the right (and removed the very old Koma seq)
image

What do you think?

What is the workflow that this could help? It would be really nice if the thing just detected changes in the file and reloaded it when changed, but this is a good intermediate step.

@mcgrathcm
Copy link
Copy Markdown
Contributor Author

That looks better to me, makes more sense on the right.
In terms of workflows, I think it mostly helps for sequence debugging and tuning, since I can adjust and run a sequence building script and then check it very quickly.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 24, 2026

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.52%. Comparing base (33dab33) to head (2cbf69e).

Files with missing lines Patch % Lines
src/KomaUI.jl 70.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
- Coverage   89.80%   88.52%   -1.29%     
==========================================
  Files          76       76              
  Lines        5407     5405       -2     
==========================================
- Hits         4856     4785      -71     
- Misses        551      620      +69     
Flag Coverage Δ
base 86.47% <ø> (ø)
core 79.76% <ø> (-9.73%) ⬇️
files 95.26% <ø> (ø)
komamri 88.00% <72.72%> (-0.33%) ⬇️
plots 90.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/KomaCLI.jl 93.68% <100.00%> (ø)
src/KomaUI.jl 86.81% <70.00%> (-1.26%) ⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cncastillo cncastillo merged commit 830f42a into JuliaHealth:master May 25, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants