Skip to content

(WIP) Phantom time dependent properties#794

Draft
pvillacorta wants to merge 2 commits into
masterfrom
feature/phantom-time-dependent-properties
Draft

(WIP) Phantom time dependent properties#794
pvillacorta wants to merge 2 commits into
masterfrom
feature/phantom-time-dependent-properties

Conversation

@pvillacorta
Copy link
Copy Markdown
Collaborator

This PR started as I needed to simulate variability in the ρ field of the Phantom. I then extended it to the rest of vector fields (T1, T2, ...). For now, it is functional, but it is still a work in progress. I just leave it here so anyone interested could use it or improve it so far.

Additionally, some thoughts came to my mind related to change the way motion is defined. Maybe we could include motion directly as trajectories within the x, y and z fields, and avoid using a dedicated motion field. We might think a bit more in depth regarding this.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

❌ Patch coverage is 81.85654% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.20%. Comparing base (33dab33) to head (b1f95f6).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
KomaMRIPlots/src/ui/DisplayFunctions.jl 75.51% 12 Missing ⚠️
...ase/src/datatypes/phantom/TimeDependentProperty.jl 64.51% 11 Missing ⚠️
KomaMRIBase/src/motion/SpinSpan.jl 0.00% 10 Missing ⚠️
...re/src/simulation/SimMethods/Bloch/gpu/BlochGPU.jl 0.00% 6 Missing ⚠️
KomaMRICore/src/simulation/Flow.jl 86.95% 3 Missing ⚠️
KomaMRIBase/src/datatypes/Phantom.jl 93.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
- Coverage   89.80%   88.20%   -1.61%     
==========================================
  Files          76       77       +1     
  Lines        5407     5544     +137     
==========================================
+ Hits         4856     4890      +34     
- Misses        551      654     +103     
Flag Coverage Δ
base 85.77% <67.16%> (-0.71%) ⬇️
core 79.88% <89.02%> (-9.61%) ⬇️
files 95.36% <100.00%> (+0.10%) ⬆️
komamri 88.00% <ø> (-0.33%) ⬇️
plots 90.02% <75.51%> (-0.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
KomaMRIBase/src/KomaMRIBase.jl 85.71% <ø> (ø)
KomaMRIBase/src/motion/MotionList.jl 100.00% <100.00%> (ø)
KomaMRIBase/src/motion/NoMotion.jl 96.00% <100.00%> (ø)
KomaMRIBase/src/timing/Interpolation.jl 96.00% <100.00%> (ø)
KomaMRIBase/src/timing/TimeCurve.jl 95.83% <ø> (ø)
KomaMRICore/src/simulation/Functors.jl 63.63% <ø> (-13.64%) ⬇️
...re/src/simulation/SimMethods/Bloch/cpu/BlochCPU.jl 100.00% <100.00%> (ø)
...e/src/simulation/SimMethods/BlochDict/BlochDict.jl 89.47% <100.00%> (+1.59%) ⬆️
...ation/SimMethods/BlochMagnus/cpu/BlochMagnusCPU.jl 100.00% <100.00%> (ø)
...c/simulation/SimMethods/BlochSimple/BlochSimple.jl 91.48% <100.00%> (+1.24%) ⬆️
... and 8 more

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant