(WIP) Phantom time dependent properties#794
Draft
pvillacorta wants to merge 2 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #794 +/- ##
==========================================
- Coverage 89.80% 88.20% -1.61%
==========================================
Files 76 77 +1
Lines 5407 5544 +137
==========================================
+ Hits 4856 4890 +34
- Misses 551 654 +103
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR started as I needed to simulate variability in the
ρfield of the Phantom. I then extended it to the rest of vector fields (T1, T2, ...). For now, it is functional, but it is still a work in progress. I just leave it here so anyone interested could use it or improve it so far.Additionally, some thoughts came to my mind related to change the way motion is defined. Maybe we could include motion directly as trajectories within the
x,yandzfields, and avoid using a dedicatedmotionfield. We might think a bit more in depth regarding this.