Open
Conversation
Author
|
I also tried unsafe_wrapping for types containing arrays, like Dates.CompoundPeriod, which cannot be written with this solution. EDIT: I think I misinterpreted an error message and couldn't reproduce, so please ignore this post. |
Author
|
@DhairyaLGandhi not sure whom to ask for a review, could you help? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #121
Not sure, what a good way of warning could be. Currently I spit out a warning every time, which is probably not the best idea for the final version.
Mikmoore's comments on discourse were very helpful for finding this solution.