Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove num_tokens argument from bump_glue #338

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Remove num_tokens argument from bump_glue #338

merged 1 commit into from
Aug 12, 2023

Conversation

sunxd3
Copy link
Contributor

@sunxd3 sunxd3 commented Aug 5, 2023

Resolve #331.

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #338 (f672f69) into main (84ccafe) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files          14       14           
  Lines        4158     4158           
=======================================
  Hits         4015     4015           
  Misses        143      143           
Files Changed Coverage Δ
src/parse_stream.jl 93.89% <100.00%> (ø)
src/parser.jl 98.03% <100.00%> (ø)

@c42f
Copy link
Member

c42f commented Aug 12, 2023

Awesome, thanks!!

@c42f c42f merged commit 94bad1a into JuliaLang:main Aug 12, 2023
31 checks passed
c42f pushed a commit that referenced this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump_glue next_byte disregard num_tokens
2 participants