Fix hanging system image creation if multiple threads are set #1042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure, that the final system image is built single-threaded and override any values set by "-t", "--threads" in sysimage_build_args` or provided via JULIA_NUM_THREADS. This is needed until the underlying bug is fixed (see JuliaLang#963 and especially JuliaLang#990 containing a `git bisect` to the commit introducing the problem) Fixes JuliaLang#963 and JuliaLang#990
|
I have a wish: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1042 +/- ##
=======================================
Coverage 86.16% 86.16%
=======================================
Files 3 3
Lines 795 795
=======================================
Hits 685 685
Misses 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks. I can confirm it fixes the problem, see also my post in Discourse |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure, that the final system image is built single-threaded and override any values set by "-t", "--threads" in sysimage_build_args
or provided via JULIA_NUM_THREADS. This is needed until the underlying bug is fixed (see #963 and especially #990 containing agit bisect` to the commit introducing the problem)Fixes #963 and #990
Supersedes #1041.
Thanks a lot to @KristofferC for the close hit with #1041 limiting down the search area enormously and also to everyone reporting or contributing to the discussions around #963 and #990, especially to @dpinol, @juanromerohb, @matthewgcooper and last, but certainly not least for a lot of patience with
git bisect, to @paulmelis.