Widen copy_globs to accept any Glob.glob pattern type#1088
Closed
asinghvi17 wants to merge 1 commit into
Closed
Conversation
Addresses review feedback from @bauglir: allow copy_globs elements to be anything Glob.glob accepts (String, GlobMatch, Vector of matchers including FilenameMatch, Regex, etc.) instead of only String. This enables case-insensitive matching via e.g. `[[fn"license*"i]]`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
CI seems to fail |
Contributor
Author
|
This is integrated upstream now so we no longer need this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
copy_globsfromVector{String}toVectorso each element can be anythingGlob.globaccepts: aString,GlobMatch, orVectorof matchers (includingRegex,Glob.FilenameMatch, etc.)copy_globs=[[fn"license*"i]]isa AbstractStringguard on the**special-case so non-string patterns fall through toglob()directlyAddresses review feedback from @bauglir.
Test plan
Vector{String}still works (backward compatible)GlobMatch,FilenameMatch, and mixed vectors are acceptedisa AbstractStringguard correctly dispatches string vs non-string patterns🤖 Generated with Claude Code