Separate printing logic from bundle logic

[topolarity]

This allows downstream consumers like JuliaC to report sizes more accurately after deleting / stripping libraries or deleting artifacts, etc. or to skip printing these entirely for automated CLI usage.

It's also a nice re-factor anyway.

Drafted by Claude Opus 🤖 and touched up + reviewed by me.

[codecov]

Codecov Report

❌ Patch coverage is 96.33028% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.13%. Comparing base (ae30359) to head (5e3d715).

Files with missing lines	Patch %	Lines
ext/TerminalSpinners.jl	20.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1110      +/-   ##
==========================================
+ Coverage   85.43%   86.13%   +0.69%     
==========================================
  Files           3        3              
  Lines         831      887      +56     
==========================================
+ Hits          710      764      +54     
- Misses        121      123       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[KristofferC]

Is it overkill to have the printer be passed into as a function so that the printing actually happens at the same time things are bundled? I kind of like that experience instead of nothing happening for 10s and then the terminal just got a full blast of stuff.

[topolarity]

Is it overkill to have the printer be passed into as a function so that the printing actually happens at the same time things are bundled? I kind of like that experience instead of nothing happening for 10s and then the terminal just got a full blast of stuff.

Hmm, that's challenging to make work with the JuliaC workflow where we'll strip / remove artifacts downstream so the printing really does have to happen after-the-fact

Any ideas?

[topolarity]

@KristofferC I'd like to merge this soon, so that I can use it for some additional JuliaC CI in JuliaLang/julia

Let me know if you object - happy to try a different approach

[KristofferC]

Well, my thinking is right now that the printing also works sort of like a progress bar, copying a lot of artifacts usually takes some time and seeing artifact by artifact getting copied visually gives a sense of progress and avoids it looking like PackageCompiler got stuck. Is it possible to keep that "feeling" while still working for the JuliC use case?

[topolarity]

Is it possible to keep that "feeling" while still working for the JuliC use case?

What if we add a proper progress bar? 😉

[KristofferC]

Does flipping the axis of progress from vertical to horizontal help JuliaC? :P

[topolarity]

Does flipping the axis of progress from vertical to horizontal help JuliaC? :P

Yes, it does - because then the progress doesn't have to print library / artifact sizes that are incorrect for your final bundle

Just pushed a pair of commits, so let me know what you think. It's not a proper progress bar, but hopefully it's enough to feel OK: Package Compiler: bundling artifacts (3/8): Cuda_jll