Link against libstdc++ from CSL on windows #58151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zentrik
added
building
Zentrik
force-pushed
the
Zentril/windows_libstdc_csl
branch
from
72b8c8b to
4849489
Compare
gbaraldi
approved these changes
Apr 17, 2025
giordano
reviewed
Apr 19, 2025
| @@ -120,6 +120,7 @@ ifeq ($(OS),WINNT) | |||
| GCC_VERSION = 14 | |||
| install-csl: | |||
| mkdir -p $(build_private_libdir)/ | |||
| cp -a $(build_shlibdir)/$(call versioned_libname,libstdc++,6) $(build_shlibdir)/libstdc++.$(SHLIB_EXT) | |||
There was a problem hiding this comment.
Shouldn't this be uninstalled below? Also, how come we weren't installing libstdc++ already?
There was a problem hiding this comment.
Let me check. We install libstdc++-6.dll, but when building libjulia-internal we link against static libraries from llvm and the libstdc++.dll, which ends up coming from the system. Due to the system libstdc++ not having some of the symbols libstdc++-6.dll has, the build fails. Explained in more detail at #57021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #57021. Split out from #58142, not sure if there is a better way to fix this.