[WIP] Refactor in-place dispatch route – improve developer docs - #630
Draft
kellertuer wants to merge 110 commits into
Draft
[WIP] Refactor in-place dispatch route – improve developer docs#630kellertuer wants to merge 110 commits into
kellertuer wants to merge 110 commits into
Conversation
…ameter from the AbstractManifoldObjective – introduce a wrapper AllocatingManifoldFunction instead.
… first order plan.
… few solver state wrappers.
so that all functions are marked as missing if not provided.
…InplaceFunction – and somehow nearly every solver now seems to suffer from side effects :(
…ng when...missing – and no longer nothing.
…y resolved the problem for ALM. ...but at least it is down to 3 solvers to fix left: EPN, DoC, ProxBundle, which do not yet converge.
…(inplace or Inplace-wrapped) functions when requested.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #630 +/- ##
===========================================
- Coverage 100.00% 99.40% -0.60%
===========================================
Files 102 90 -12
Lines 12957 12521 -436
===========================================
- Hits 12957 12446 -511
- Misses 0 75 +75 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #610. Since it is a larger refactor, I wanted to open this PR a bit earlier so it is visible and people are aware, the code base is changing quite a bit.
Goal of this PR / Refactor
EvaluationType- it was not reflected in any of the fields per se and a bit clumsy anyways (and maybe just a very early wrong design decision back then)plan/folder is split intobase/folder defining and describing interfacescommons/folder collecting implementations several solvers have in common, like stopping criteriaplan/also move to their respective solvers, if there is no incentive to have these in thecommonsareaWhile parameters of several structs change, especially all objectives “loose” their first parameter, the hope is that in the end all constructors stay the same and hence this PR is non-breaking.
Roadmap
evaluation =keywords thereonplan/tobase/andcommons/– as a structured way to work through all points from the previous itemevalution =to the objectives such that they wrap their function components accordingly. This would mean “wrapping” all functions to (internally) be allocating.AllocatingManifoldFunctionserver well enough so wrap single allocating functionsTLDR
The information “in-place or allocating” gets “more modular” within the objective, code complexity is reduced – and we get developer docs as a side aspect.