Merge branch 'master' into fix-temme-iop2-and-iop3-wide

Author: devmotion

Project.toml

@@ -21,7 +21,7 @@ ChainRulesCore = "0.9.44, 0.10, 1"
 ChainRulesTestUtils = "0.6.8, 0.7, 1"
 ExplicitImports = "1.13.2"
 IrrationalConstants = "0.1, 0.2"
-JET = "0.9, 0.10"
+JET = "0.9, 0.12"
 LogExpFunctions = "0.3.2, 1"
 OpenLibm_jll = "0.7, 0.8"
 OpenSpecFun_jll = "0.5"

test/gamma_inc.jl

@@ -364,6 +364,14 @@ end
     @test_throws DomainError loggamma(6, -3.2)
 end
 
+# Run `f(args...)` twice and return only the result of the second call, so that
+# one-time costs of the first execution of a freshly compiled callsite are not
+# measured. On Julia >= 1.13 OpenLibm is a `Libdl.LazyLibrary`, so resolving the
+# target of a `ccall` into it allocates 16 bytes on that callsite's first
+# execution. Warming up with a separate call does not help, because the binding
+# is cached per callsite and not per callee.
+run_twice(f, args...) = (f(args...); f(args...))
+
 @testset "GPU compatibility ($FT)" for FT in (Float64, Float32, Float16)
     # Note: This test is a proxy for GPU compatibility by checking that the functions
     # are type stable and do not allocate memory. It does not launch any GPU kernels.
@@ -378,38 +386,38 @@ end
         # `@allocated` checks for allocations for specific code paths
         ## a >= 1
         ### gamma_inc_temme_1: simplified Temme expansion
-        @test iszero((FT -> @allocated(gamma_inc(FT(30.0), FT(29.99999), 0)))(FT))
+        @test iszero(run_twice(FT -> @allocated(gamma_inc(FT(30.0), FT(29.99999), 0)), FT))
         ### gamma_inc_minimax: minimax approximation
-        @test iszero((FT -> @allocated(gamma_inc(FT(100.0), FT(80.0), 0)))(FT))
+        @test iszero(run_twice(FT -> @allocated(gamma_inc(FT(100.0), FT(80.0), 0)), FT))
         ### gamma_inc_temme: Temme expansion
-        @test iszero((FT -> @allocated(gamma_inc(FT(100.0), FT(80.0), 1)))(FT))
+        @test iszero(run_twice(FT -> @allocated(gamma_inc(FT(100.0), FT(80.0), 1)), FT))
         ### gamma_inc_cf: Continued fraction
-        @test iszero((FT -> @allocated(gamma_inc(FT(1.7), FT(2.5))))(FT))
+        @test iszero(run_twice(FT -> @allocated(gamma_inc(FT(1.7), FT(2.5))), FT))
         ### gamma_inc_taylor: Taylor series
-        @test iszero((FT -> @allocated(gamma_inc(FT(11.1), FT(0.001))))(FT))
+        @test iszero(run_twice(FT -> @allocated(gamma_inc(FT(11.1), FT(0.001))), FT))
         ### gamma_inc_asym: Asymptotic expansion
-        @test iszero((FT -> @allocated(gamma_inc(FT(10.0), FT(35.0))))(FT))
+        @test iszero(run_twice(FT -> @allocated(gamma_inc(FT(10.0), FT(35.0))), FT))
         ### gamma_inc_fsum: Finite sums
-        @test iszero((FT -> @allocated(gamma_inc(FT(24.0), FT(25))))(FT))
+        @test iszero(run_twice(FT -> @allocated(gamma_inc(FT(24.0), FT(25))), FT))
         ## a==0.5
         ### erfc
-        @test iszero((FT -> @allocated(gamma_inc(FT(0.5), FT(0.5))))(FT))
+        @test iszero(run_twice(FT -> @allocated(gamma_inc(FT(0.5), FT(0.5))), FT))
         ## x < 1.1
         ### gamma_inc_taylor_x
-        @test iszero((FT -> @allocated(gamma_inc(FT(0.9), FT(0.8))))(FT))
+        @test iszero(run_twice(FT -> @allocated(gamma_inc(FT(0.9), FT(0.8))), FT))
         ## else
         ### gamma_inc_cf
-        @test iszero((FT -> @allocated(gamma_inc(FT(0.7), FT(2.5))))(FT))
+        @test iszero(run_twice(FT -> @allocated(gamma_inc(FT(0.7), FT(2.5))), FT))
     end
 
     @testset "gamma_inc_inv allocations" begin
         # `@allocated` checks for allocations for specific code paths
         ## x0 approximation paths
         ### gamma_inc_inv_psmall
-        @test iszero((FT -> @allocated(gamma_inc_inv(FT(1.0), FT(0.01), FT(0.99))))(FT))
+        @test iszero(run_twice(FT -> @allocated(gamma_inc_inv(FT(1.0), FT(0.01), FT(0.99))), FT))
         ### gamma_inc_inv_qsmall
-        @test iszero((FT -> @allocated(gamma_inc_inv(FT(5.0), FT(0.99), FT(0.01))))(FT))
+        @test iszero(run_twice(FT -> @allocated(gamma_inc_inv(FT(5.0), FT(0.99), FT(0.01))), FT))
         ### gamma_inc_inv_alarge
-        @test iszero((FT -> @allocated(gamma_inc_inv(FT(50.0), FT(0.3), FT(0.7))))(FT))
+        @test iszero(run_twice(FT -> @allocated(gamma_inc_inv(FT(50.0), FT(0.3), FT(0.7))), FT))
     end
 end

test/qa.jl

@@ -54,10 +54,12 @@ end
     @test ExplicitImports.check_no_self_qualified_accesses(SpecialFunctions) === nothing
 end
 
-@testset "JET" begin
-    # Check that there are no undefined global references and undefined field accesses
-    JET.test_package(SpecialFunctions; target_defined_modules = true, mode = :typo)
+if VERSION < v"1.12" || JET.JET_AVAILABLE
+    @testset "JET" begin
+        # Check that there are no undefined global references and undefined field accesses
+        JET.test_package(SpecialFunctions; target_modules = (SpecialFunctions,), mode = :typo)
 
-    # Analyze methods based on their declared signature
-    JET.report_package(SpecialFunctions; target_defined_modules = true)
+        # Analyze methods based on their declared signature
+        JET.report_package(SpecialFunctions; target_modules = (SpecialFunctions,))
+    end
 end