remove pieces specific to old julia versions

Author: aplavin

src/ConstructionBase.jl

@@ -168,8 +168,4 @@ end
 include("nonstandard.jl")
 include("functions.jl")
 
-if !isdefined(Base, :get_extension)
-    include("../ext/ConstructionBaseLinearAlgebraExt.jl")
-end
-
 end # module

src/nonstandard.jl

@@ -36,5 +36,5 @@ linrange_constructor(start, stop, len, lendiv) = LinRange(start, stop, len)
 constructorof(::Type{<:LinRange}) = linrange_constructor
 
 ### Expr: args get splatted
-# ::Expr annotation is to make it type-stable on Julia 1.3-
+# ::Expr annotation is to make it type-stable on Julia 1.3-, probably not necessary anymore
 constructorof(::Type{<:Expr}) = (head, args) -> Expr(head, args...)::Expr

test/runtests.jl

@@ -353,8 +353,6 @@ Base.getproperty(s::SProp, prop::Symbol) = "ps$prop"
 Base.getproperty(s::SProp, prop::Int) = "pi$prop"
 Base.getproperty(s::SProp, prop::String) = "pstr$prop"
 
-# automatic getproperties() supported only on 1.7+
-
 @testset "properties can be numbered" begin
     @test getproperties(SProp((:a, :b))) === (a="psa", b="psb")
     @test getproperties(SProp((1, 2))) === ("pi1", "pi2")
@@ -551,45 +549,43 @@ end
 
 using StaticArrays, IntervalSets
 
-if isdefined(Base, :get_extension)  # some 1.9 version
-    @testset "staticarrays" begin
-        sa = @SVector [2, 4, 6, 8]
-        sa2 = ConstructionBase.constructorof(typeof(sa))((3.0, 5.0, 7.0, 9.0))
-        @test sa2 === @SVector [3.0, 5.0, 7.0, 9.0]
-
-        ma = @MMatrix [2.0 4.0; 6.0 8.0]
-        ma2 = @inferred ConstructionBase.constructorof(typeof(ma))((1, 2, 3, 4))
-        @test ma2 isa MArray{Tuple{2,2},Int,2,4}
-        @test all(ma2 .=== @MMatrix [1 3; 2 4])
-
-        sz = SizedArray{Tuple{2,2}}([1 2;3 4])
-        sz2 = @inferred ConstructionBase.constructorof(typeof(sz))([:a :b; :c :d])
-        @test sz2 == SizedArray{Tuple{2,2}}([:a :b; :c :d])
-        @test typeof(sz2) <: SizedArray{Tuple{2,2},Symbol,2,2}
-
-        for T in (SVector, MVector)
-            @test @inferred(ConstructionBase.constructorof(T)((1, 2, 3)))::T == T((1, 2, 3))
-            @test @inferred(ConstructionBase.constructorof(T{3})((1, 2, 3)))::T == T((1, 2, 3))
-            @test @inferred(ConstructionBase.constructorof(T{3})((1, 2)))::T == T((1, 2))
-            @test @inferred(ConstructionBase.constructorof(T{3, Symbol})((1, 2, 3)))::T == T((1, 2, 3))
-            @test @inferred(ConstructionBase.constructorof(T{3, Symbol})((1, 2)))::T == T((1, 2))
-            @test @inferred(ConstructionBase.constructorof(T{3, X} where {X})((1, 2, 3)))::T == T((1, 2, 3))
-            @test @inferred(ConstructionBase.constructorof(T{3, X} where {X})((1, 2)))::T == T((1, 2))
-            @test @inferred(ConstructionBase.constructorof(T{X, Symbol} where {X})((1, 2, 3)))::T == T((1, 2, 3))
-        end
-
-        sv = SVector(1, 2)
-        @test SVector(3.0, 2.0) === @inferred setproperties(sv, x = 3.0)
-        @test SVector(3.0, 5.0) === @inferred setproperties(sv, x = 3.0, y = 5.0)
-        @test SVector(-1.0, -2.0) === @inferred setproperties(sv, data = (-1.0, -2))
-        @test_throws "does not have properties z" setproperties(sv, z = 3.0)
-        @test_throws "does not have properties z" setproperties(SVector(1, 2, 3, 4, 5), z = 3.0)
+@testset "staticarrays" begin
+    sa = @SVector [2, 4, 6, 8]
+    sa2 = ConstructionBase.constructorof(typeof(sa))((3.0, 5.0, 7.0, 9.0))
+    @test sa2 === @SVector [3.0, 5.0, 7.0, 9.0]
+
+    ma = @MMatrix [2.0 4.0; 6.0 8.0]
+    ma2 = @inferred ConstructionBase.constructorof(typeof(ma))((1, 2, 3, 4))
+    @test ma2 isa MArray{Tuple{2,2},Int,2,4}
+    @test all(ma2 .=== @MMatrix [1 3; 2 4])
+
+    sz = SizedArray{Tuple{2,2}}([1 2;3 4])
+    sz2 = @inferred ConstructionBase.constructorof(typeof(sz))([:a :b; :c :d])
+    @test sz2 == SizedArray{Tuple{2,2}}([:a :b; :c :d])
+    @test typeof(sz2) <: SizedArray{Tuple{2,2},Symbol,2,2}
+
+    for T in (SVector, MVector)
+        @test @inferred(ConstructionBase.constructorof(T)((1, 2, 3)))::T == T((1, 2, 3))
+        @test @inferred(ConstructionBase.constructorof(T{3})((1, 2, 3)))::T == T((1, 2, 3))
+        @test @inferred(ConstructionBase.constructorof(T{3})((1, 2)))::T == T((1, 2))
+        @test @inferred(ConstructionBase.constructorof(T{3, Symbol})((1, 2, 3)))::T == T((1, 2, 3))
+        @test @inferred(ConstructionBase.constructorof(T{3, Symbol})((1, 2)))::T == T((1, 2))
+        @test @inferred(ConstructionBase.constructorof(T{3, X} where {X})((1, 2, 3)))::T == T((1, 2, 3))
+        @test @inferred(ConstructionBase.constructorof(T{3, X} where {X})((1, 2)))::T == T((1, 2))
+        @test @inferred(ConstructionBase.constructorof(T{X, Symbol} where {X})((1, 2, 3)))::T == T((1, 2, 3))
     end
 
-    @testset "intervalsets" begin
-        @test constructorof(typeof(1..2))(0.5, 1.5) === 0.5..1.5
-        @test constructorof(typeof(OpenInterval(1, 2)))(0.5, 1.5) === OpenInterval(0.5, 1.5)
-        @test setproperties(1..2, left=0.0) === 0.0..2.0
-        @test setproperties(OpenInterval(1.0, 2.0), left=1, right=5) === OpenInterval(1, 5)
-    end
+    sv = SVector(1, 2)
+    @test SVector(3.0, 2.0) === @inferred setproperties(sv, x = 3.0)
+    @test SVector(3.0, 5.0) === @inferred setproperties(sv, x = 3.0, y = 5.0)
+    @test SVector(-1.0, -2.0) === @inferred setproperties(sv, data = (-1.0, -2))
+    @test_throws "does not have properties z" setproperties(sv, z = 3.0)
+    @test_throws "does not have properties z" setproperties(SVector(1, 2, 3, 4, 5), z = 3.0)
+end
+
+@testset "intervalsets" begin
+    @test constructorof(typeof(1..2))(0.5, 1.5) === 0.5..1.5
+    @test constructorof(typeof(OpenInterval(1, 2)))(0.5, 1.5) === OpenInterval(0.5, 1.5)
+    @test setproperties(1..2, left=0.0) === 0.0..2.0
+    @test setproperties(OpenInterval(1.0, 2.0), left=1, right=5) === OpenInterval(1, 5)
 end