Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 1 1
Lines 14 14
=======================================
Hits 13 13
Misses 1 1
Continue to review full report at Codecov.
|
tkf
force-pushed
the
setproperties-spec
branch
from
ca20b8a to
36a013d
Compare
tkf
force-pushed
the
setproperties-spec
branch
from
36a013d to
015d28c
Compare
Member
|
LGTM |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 92.85% 92.85%
=======================================
Files 1 1
Lines 14 14
=======================================
Hits 13 13
Misses 1 1 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current
setpropertiesspec indicates that users need to support arbitrarypatchobject. Doing this in general requires unnecessary reflection-based code (e.g., you don't need to usefieldnamesforNamedTuples as you can just dispatch on::NamedTuple{names}). Instead, why not specify that it is only required to overloadsetproperties(::MyType, ::NamedTuple)? We may also need to support other patch types in the future (e.g.,Dict). Restricting the patch type would help it.