fix for FunctionConstructor UB#100
Closed
vtjnash wants to merge 3 commits intoJuliaObjects:masterfrom
Closed
Conversation
rafaqz
approved these changes
Mar 15, 2025
Member
rafaqz
left a comment
rafaqz
left a comment
There was a problem hiding this comment.
Thanks, I think it was only like this because constructorof also followed this pattern of using parentmodule and nameof rather than .wrapper.
There may have been some concerns about using internals.
Merged
Member
|
Could you please rebase on master? CI was cleaned up there to avoid almost all spurious test failures. |
Contributor
|
can be closed now, the changes are merged with #104 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to bugfix in #99