Conversation
|
Setfield tests seem to be failing on 1.10 and 1.11. I guess it's just a matter of too aggressive timing comparison... Is it ok to remove Setfield on 1.10+ from integration tests for now, @jw3126? Flatten appears to be genuinely broken on 1.11. Is it ok to remove Flatten on 1.11+ from integration tests for now, @rafaqz? |
|
Yeah noticed these, a lot of changes in Base Flatten.jl is still apparently working in practice where it's used, so may also be some tests like thosr in Setfield. It just hasn't had any new PRs on 1.11. I'll try to look at it this week it's good to have tested here |
|
I guess I'll merge as-is, we'll just keep in mind these three failures for now. It is definitely an improvement already. |
|
Thanks |
|
Thanks. Setfield.jl can be removed in future. |
The goal is to make all CI tests pass, so that logs from other PRs can be assessed more easily (specifically #99 and #100).