Define constructorof for Tuple and NamedTuple?#16
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 92.85% 93.75% +0.89%
==========================================
Files 1 1
Lines 14 16 +2
==========================================
+ Hits 13 15 +2
Misses 1 1
Continue to review full report at Codecov.
|
For fun, #17 implements a type-stable |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 92.85% 93.75% +0.89%
==========================================
Files 1 1
Lines 14 16 +2
==========================================
+ Hits 13 15 +2
Misses 1 1 ☔ View full report in Codecov by Sentry. |
I started implementing this because I remember doing something similer in Kaleido.jl but then realized that what I did in Kaleido.jl is a bit differnt from actual
constructorofspec. So, this PR is not driven by a real need at this point. However, sinceTupleandNamedTupleare so basic that I think it makes sense to support this. What do you think?(One potential benefit was that we can remove
setproperties(::NamedTuple, ::NamedTuple)with this PR. But the inference test failed with the generic fallback so that's no go.)