Merge pull request #2 from JuliaPackaging/mg/have-color

Get value of `Base.have_color` with `something`

Author: giordano

Project.toml

@@ -1,7 +1,7 @@
 name = "OutputCollectors"
 uuid = "6c11c7d4-943b-4e2b-80de-f2cfc2930a8c"
 authors = ["Elliot Saba <[email protected]>"]
-version = "0.1.0"
+version = "0.1.1"
 
 [compat]
 julia = "1"

src/OutputCollectors.jl

@@ -7,6 +7,18 @@ import Base: wait, merge
 
 export OutputCollector, merge, collect_stdout, collect_stderr, tail, tee
 
+# Make sure we don't have problems when `Base.have_color` is `nothing`.
+function get_have_color()
+    @static if isdefined(Base, :get_have_color)
+        return Base.get_have_color()
+    else
+        # Compatibility with Julia v1.4-.  Layman check for coloured output on
+        # older Julia versions.  TODO: remove this function when we drop support
+        # for oldere versions of Julia.
+        return something(Base.have_color, false)
+    end
+end
+
 struct LineStream
     pipe::Pipe
     lines::Vector{Tuple{Float64,String}}
@@ -168,7 +180,7 @@ function wait(collector::OutputCollector)
         # If we failed, print out the tail of the output, unless we've been
         # tee()'ing it out this whole time, but only if the user said it's okay.
         if !success(collector.P) && !collector.verbose && collector.tail_error
-            our_tail = tail(collector; colored=Base.have_color)
+            our_tail = tail(collector; colored=get_have_color())
             print(collector.tee_stream, our_tail)
         end
     end
@@ -290,7 +302,7 @@ end
 Spawn a background task to incrementally output lines from `collector` to the
 standard output, optionally colored.
 """
-function tee(c::OutputCollector; colored::Bool=Base.have_color,
+function tee(c::OutputCollector; colored::Bool=get_have_color(),
              stream::IO=stdout)
     tee_task = @async begin
         out_idx = 1