Skip to content

Commit cd7ebe5

Browse files
committed
Reduced expand_microarchitectures to armv7l-*-march+neonvfpv4
1 parent 06cbdb6 commit cd7ebe5

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

X/XNNPACK/build_tarballs.jl

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,17 @@ atomic_patch -p1 ../patches/xnnpack-soversion.patch
3333
atomic_patch -p1 ../patches/xnnpack-freebsd.patch
3434
atomic_patch -p1 ../patches/xnnpack-w64-system-libs.patch
3535
C_FLAGS=()
36-
if [[ $bb_full_target == arm*march+neonvfpv4* ]]; then
36+
if [[ $bb_full_target == armv7l-*march+neonvfpv4 ]]; then
3737
atomic_patch -p1 ../patches/xnnpack-arm-exclude-microkernel-srcs.patch
3838
C_FLAGS+="-DXNN_NO_F32_OPERATORS "
3939
C_FLAGS+="-DXNN_NO_QS8_OPERATORS "
40-
elif [[ $bb_full_target == aarch64-*march+armv8* ]]; then
40+
elif [[ $bb_full_target == aarch64-* ]]; then # Building for aarch64-*march+armv8*
4141
atomic_patch -p1 ../patches/xnnpack-aarch64-exclude-microkernel-srcs.patch
4242
atomic_patch -p1 ../patches/xnnpack-aarch64-armv8-exclude-microkernel-srcs.patch
4343
C_FLAGS+="-DXNN_NO_F16_OPERATORS "
4444
C_FLAGS+="-DXNN_NO_F32_OPERATORS "
4545
C_FLAGS+="-DXNN_NO_QS8_OPERATORS "
46-
# elif [[ $bb_full_target == aarch64-apple-*march+apple_m1* ]]; then # This should work when Yggdrasil is on Julia 1.8
46+
# elif [[ $bb_full_target == aarch64-apple-*march+apple_m1* ]]; then # Requires build for specific micro-architecture
4747
# atomic_patch -p1 ../patches/xnnpack-aarch64-exclude-microkernel-srcs.patch
4848
# C_FLAGS+="-DXNN_NO_F16_OPERATORS "
4949
fi
@@ -73,10 +73,7 @@ install_license ../LICENSE
7373
platforms = supported_platforms()
7474
filter!(p -> arch(p) != "armv6l", platforms) # armv6l is unsupported by XNNPACK (lacks NEON instructions)
7575
filter!(p -> arch(p) != "powerpc64le", platforms) # PowerPC64LE is unsupported by XNNPACK (Unsupported architecture in src/init.c)
76-
platforms = expand_microarchitectures(platforms, [
77-
"armv8_0", "armv8_1", "armv8_2_crypto", # "apple_m1",
78-
"neonvfpv4",
79-
])
76+
platforms = expand_microarchitectures(platforms, ["neonvfpv4"]) # NEON instructions needed for armv7l
8077

8178
# The products that we will ensure are always built
8279
products = [

0 commit comments

Comments
 (0)