Skip to content

Commit dadefa6

Browse files
committed
Added NVTX RuntimeDependency
1 parent 14acc71 commit dadefa6

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

T/Torch/build_tarballs.jl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -243,6 +243,11 @@ dependencies = [
243243
Dependency("LAPACK_jll"; platforms = openblas_platforms),
244244
# Dependency("MKL_jll"; platforms = mkl_platforms), # MKL is avoided for all platforms
245245
# BuildDependency("MKL_Headers_jll"; platforms = mkl_platforms), # MKL is avoided for all platforms
246+
247+
# libtorch, libtorch_cuda, and libtorch_global_deps all link with `libnvToolsExt`
248+
# maleadt: `libnvToolsExt is not shipped by CUDA anymore, so the best solution is definitely static linking. CUDA 10.2 shipped it, later it became a header-only library which we do compile into a dynamic one for use with NVTX.jl, but there's no guarantees that the library we build has the same symbols as the "old" libnvToolsExt shipped by CUDA 10.2
249+
RuntimeDependency("NVTX_jll"), # TODO: Replace RuntimeDependency with static linking.
250+
246251
Dependency("OpenBLAS32_jll"; platforms = openblas_platforms),
247252
Dependency("PThreadPool_jll"; compat = "0.0.20210414"),
248253
Dependency("SLEEF_jll", v"3.5.2"; compat = "3"),

0 commit comments

Comments
 (0)