-
Notifications
You must be signed in to change notification settings - Fork 50
Open
Labels
convenienceImprove user-friendlinessImprove user-friendlinessenhancementImprovement of existing featuresImprovement of existing featuresgood first issueGood for newcomersGood for newcomers
Milestone
Description
The current clustering algorithm in https://github.com/JuliaPhysics/SolidStateDetectors.jl/blob/main/src/ChargeClustering/ChargeClustering.jl only clusters by position, but does not consider timing information.
Similar to a cluster_radius, it might also make sense to add a cluster_time.
Also, when clustering a Geant4 output table, the times thit are not clustered but remain untouched.
SolidStateDetectors.jl/src/ChargeClustering/ChargeClustering.jl
Lines 59 to 74 in e68da8b
| function cluster_detector_hits(table::TypedTables.Table, cluster_radius::RealQuantity) | |
| @assert :pos in TypedTables.columnnames(table) "Table has no column `pos`" | |
| @assert :edep in TypedTables.columnnames(table) "Table has no column `edep`" | |
| @assert :detno in TypedTables.columnnames(table) "Table has no column `detno`" | |
| clustered_nt = map( | |
| evt -> cluster_detector_hits(evt.detno, evt.edep, evt.pos, cluster_radius), | |
| table | |
| ) | |
| TypedTables.Table(merge( | |
| TypedTables.columns(table), | |
| map( | |
| VectorOfVectors, | |
| TypedTables.columns(clustered_nt) | |
| ) | |
| )) | |
| end |
It might make sense to add (optional) clustering of
thit also here.Metadata
Metadata
Assignees
Labels
convenienceImprove user-friendlinessImprove user-friendlinessenhancementImprovement of existing featuresImprovement of existing featuresgood first issueGood for newcomersGood for newcomers