Skip to content

Commit 878a9ec

Browse files
committed
moar fixes
1 parent bbff1d7 commit 878a9ec

File tree

4 files changed

+27
-37
lines changed

4 files changed

+27
-37
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -67,31 +67,7 @@ jobs:
6767
- uses: julia-actions/cache@v2
6868
- uses: julia-actions/julia-buildpkg@latest
6969

70-
- name: Install conda based matplotlib
71-
shell: julia --project=@. --color=yes {0}
72-
run: |
73-
using Pkg; Pkg.add("CondaPkg")
74-
using CondaPkg; CondaPkg.resolve()
75-
libgcc = if Sys.islinux()
76-
# see discourse.julialang.org/t/glibcxx-version-not-found/82209/8
77-
# julia 1.8.3 is built with libstdc++.so.6.0.29, so we must restrict to this version (gcc 11.3.0, not gcc 12.2.0)
78-
# see gcc.gnu.org/onlinedocs/libstdc++/manual/abi.html
79-
specs = Dict(
80-
v"3.4.29" => ">=11.1,<12.1",
81-
v"3.4.30" => ">=12.1,<13.1",
82-
v"3.4.31" => ">=13.1,<14.1",
83-
v"3.4.32" => ">=14.1,<15.1",
84-
v"3.4.33" => ">=15.1,<16.1",
85-
# ... keep this up-to-date with gcc 16
86-
)[Base.BinaryPlatforms.detect_libstdcxx_version()]
87-
("libgcc-ng$specs", "libstdcxx-ng$specs")
88-
else
89-
()
90-
end
91-
CondaPkg.PkgREPL.add([libgcc..., "matplotlib"])
92-
CondaPkg.status()
93-
94-
- name: develop packages
70+
- name: dev pkgs and install mpl deps
9571
run: |
9672
${{ env.JULIA_PROJECT_CMD }} -e '
9773
using Pkg
@@ -100,6 +76,7 @@ jobs:
10076
(; path="./RecipesPipeline"), # compat for LTS [sources], remove later
10177
(; path="./Plots"), # compat for LTS [sources], remove later
10278
])
79+
include(joinpath(@__DIR__, "ci", "matplotlib.jl"))
10380
Pkg.precompile() # // precompilation
10481
'
10582

Plots/test/Project.toml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
33
Colors = "5ae59095-9a9b-59fe-a467-6f913c188581"
44
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
55
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f"
6+
Downloads = "f43a241f-c20a-4ad4-852c-f6b1247861c6"
67
FileIO = "5789e2e9-d7fb-5bc7-8068-2c6fae9b9549"
78
FilePathsBase = "48062228-2e41-5def-b9a4-89aafe57970f"
89
FreeType = "b38be410-82b0-50bf-ab77-7b57e271db43"
@@ -17,6 +18,7 @@ JSON = "682c06a0-de6a-54ab-a142-c8b1cf79cde6"
1718
Latexify = "23fbe1c1-3f47-55db-b15f-69d7ec21a316"
1819
LaTeXStrings = "b964fa9f-0449-5b57-a5c2-d3ea65f4040f"
1920
LibGit2 = "76f85450-5226-5b5a-8eaa-529ad045b433"
21+
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
2022
OffsetArrays = "6fe1bfb0-de20-5000-8ca7-80f57d26f881"
2123
PGFPlots = "3b7a836e-365b-5785-a47d-02c71176b4aa"
2224
PGFPlotsX = "8314cec4-20b6-5062-9cdb-752b83310925"
@@ -25,12 +27,14 @@ PlotlyJS = "f0f68f2c-4968-5e81-91da-67840de0976a"
2527
PlotlyKaleido = "f2990250-8cf9-495f-b13a-cce12b45703c"
2628
PyPlot = "d330b81b-6aea-500a-939a-2ce795aea3ee"
2729
PythonPlot = "274fc56d-3b97-40fa-a1cd-1b4a50311bf9"
30+
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
2831
RDatasets = "ce6b1742-4840-55fa-b093-852dadbb1d8b"
2932
RecipesBase = "3cdcf5f2-1ef4-517c-9805-6587b60abb01"
3033
RecipesPipeline = "01d81517-befc-4cb6-b9ec-a95719d0359c"
3134
SentinelArrays = "91c51154-3ec4-41a3-a24f-3f23e20d615c"
3235
StableRNGs = "860ef19b-820b-49d6-a774-d7a799459cd3"
3336
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
37+
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
3438
StatsPlots = "f3b207a7-027a-5e70-b257-86293d7955fd"
3539
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
3640
TestImages = "5e47fb64-e119-507b-a336-dd2b206d9990"
@@ -40,9 +44,12 @@ VisualRegressionTests = "34922c18-7c2a-561c-bac1-01e79b2c4c92"
4044

4145
[compat]
4246
Aqua = "0.8"
47+
Distributions = "0.25, 1"
4348
Gaston = "1"
4449
HDF5 = "0.16 - 0.17"
4550
InspectDR = "0.4"
51+
LibGit2 = "1"
52+
OffsetArrays = "1"
4653
PGFPlots = "3"
4754
PGFPlotsX = "1"
4855
PlotlyBase = "0.7 - 0.8"

ci/matplotlib.jl

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,18 @@ libgcc = if Sys.islinux()
3030
# julia 1.8.3 is built with libstdc++.so.6.0.29, so we must restrict to this version (gcc 11.3.0, not gcc 12.2.0)
3131
versions = Dict(_compatible_libstdcxx_ng_versions)
3232
lo, hi = extrema(keys(versions))
33-
_, ub = versions[Base.BinaryPlatforms.detect_libstdcxx_version(Int(hi.patch))]
34-
specs = ">=$(VersionNumber(lo.major, lo.minor)),$ub"
35-
("libgcc-ng$specs", "libstdcxx-ng$specs")
33+
libstdcxx_version = Base.BinaryPlatforms.detect_libstdcxx_version(Int(hi.patch))
34+
@info libstdcxx_version
35+
if libstdcxx_version nothing
36+
_, ub = versions[libstdcxx_version]
37+
specs = ">=$(VersionNumber(lo.major, lo.minor)),$ub"
38+
("libgcc-ng$specs", "libstdcxx-ng$specs")
39+
else
40+
()
41+
end
3642
else
3743
()
3844
end
3945

40-
CondaPkg.PkgREPL.add([libgcc..., "matplotlib>=3.4"]) # "openssl>=3.4"
46+
CondaPkg.PkgREPL.add([libgcc..., "matplotlib>=3.10"]) # "openssl>=3.4"
4147
CondaPkg.status()

docs/src/GraphRecipes/examples.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ graphplot(A,
3636
linecolor = :darkgrey,
3737
linealpha = 0.5
3838
)
39-
4039
```
4140

4241
### Graphs.jl
@@ -66,11 +65,11 @@ graphplot(g, names=1:3, curvature_scalar=0.1)
6665
Edge labels can be passed via the `edgelabel` keyword argument. You can pass edge labels
6766
as a dictionary of `(si::Int, di::Int) => label`, where `si`, `di` are the indices of the source and destiny nodes for the edge being labeled. Alternatively, you can pass a matrix or a vector of labels. `graphplot` will try to convert any label you pass it into a string unless you pass one of `missing`, `NaN`, `nothing`, `false` or `""`, in which case, `graphplot` will skip the label.
6867

69-
```@example graphexamples
68+
```@example
7069
using GraphRecipes, Plots
7170
using Graphs
7271
73-
n = 8
72+
const n = 8
7473
g = wheel_digraph(n)
7574
edgelabel_dict = Dict()
7675
edgelabel_mat = Array{String}(undef, n, n)
@@ -85,7 +84,7 @@ graphplot(g, names=1:n, edgelabel=edgelabel_dict, curves=false, nodeshape=:rect)
8584
```
8685

8786
#### Self edges
88-
```@example graphexamples
87+
```@example
8988
using Graphs, Plots, GraphRecipes
9089
9190
g = [1 1 1;
@@ -96,13 +95,14 @@ graphplot(DiGraph(g), self_edge_size=0.2)
9695
```
9796

9897
#### Multigraphs
99-
```@example graphexamples
98+
```@example
99+
using Graphs, Plots, GraphRecipes
100100
graphplot([[1,1,2,2],[1,1,1],[1]], names="node_".*string.(1:3), nodeshape=:circle, self_edge_size=0.25)
101101
```
102102

103103
#### Arc and chord diagrams
104104

105-
```@example graphexamples
105+
```@example
106106
using LinearAlgebra
107107
using SparseArrays
108108
using GraphRecipes
@@ -129,7 +129,7 @@ plot(
129129

130130
#### Julia code -- AST
131131

132-
```@example graphexamples
132+
```@example
133133
using GraphRecipes
134134
using Plots
135135
default(size=(1000, 1000))
@@ -150,7 +150,7 @@ plot(code, fontsize=12, shorten=0.01, axis_buffer=0.15, nodeshape=:rect)
150150

151151
#### Julia Type Trees
152152

153-
```@example graphexamples
153+
```@example
154154
using GraphRecipes
155155
using Plots
156156
default(size=(1000, 1000))

0 commit comments

Comments
 (0)