fix precompilation issue with 1.40.12 in Julia 1.12 and bump to 1.40.13#5073
Closed
lmiq wants to merge 28 commits intoJuliaPlots:v2from
Closed
fix precompilation issue with 1.40.12 in Julia 1.12 and bump to 1.40.13#5073lmiq wants to merge 28 commits intoJuliaPlots:v2from
lmiq wants to merge 28 commits intoJuliaPlots:v2from
Conversation
Bumps [julia-actions/cache](https://github.com/julia-actions/cache) from 1 to 2. - [Release notes](https://github.com/julia-actions/cache/releases) - [Commits](julia-actions/cache@v1...v2) --- updated-dependencies: - dependency-name: julia-actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Making PGFPlotsX use deterministic series IDs * updating comment and fixing code style
* add recipe to plot series objects * Update src/types.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * add test --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* lazily load Pkg * compat fixes * use 'pre' in CI * please formatter --------- Co-authored-by: Simon Christ <SimonChrist@gmx.de>
Separates grid drawing from the remainder of gr_draw_axis, so that all gridlines are drawn below the axis. Previously, y-axis gridlines were drawn after the x-axis and could overlap it. Fixes issue JuliaPlots#4202 for GR.
* Fix floating point equality comparison in layouts * Add tests for grid layout widths/heights * Add myself to .zenodo.json
* Update tests for Latexify 0.16.5
Behaviour was changed such that ã becomes \tilde{a}, instead of
\textnormal{\~{a}}.
* Test Julia 1.6 on x86 macOS instead of ARM
See: https://discourse.julialang.org/t/how-to-fix-github-actions-ci-failures-with-julia-1-6-or-1-7-on-macos-latest-and-macos-14/117019
* Bump GR compat and Plots version number
* update plotly show methods for PlotlyKaleido v2
* remove Pkg
* add it back
---------
Co-authored-by: Simon Christ <christ@cell.uni-hannover.de>
* Update Project.toml Adding support for `FFMPEG.jl` [0.4.1](https://github.com/JuliaIO/FFMPEG.jl/releases/tag/v0.4.1) which is support on MacOS on Apple Silicon. * Update Project.toml --------- Co-authored-by: Simon Christ <SimonChrist@gmx.de>
* deprecate inspctdr * Update backends.jl
This fixes JuliaPlots#4871 Only the case of :log10 has been treated before.
Update ci.yml for aarch64 mac on master
* Revert "Deprecate inspectDR (JuliaPlots#4976)" This reverts commit 18b7551. * update Aqua test
Previously, `zscale` was being set to a Bool value (the result of the set membership check). This caused a crash when querying the `gr_z_log_scales` tuple on the next line, because that array is indexed by symbols like :log10. Given that the lines above assign the actual symbols to `xscale` and `yscale`, it seems likely that `zscale` should behave the same. Fixes: JuliaPlots#5062
Contributor
Author
|
CI runs on ubuntu seem to be failing for the unrelated JuliaSIMD/ThreadingUtilities.jl#51 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v2 #5073 +/- ##
=====================================
Coverage ? 89.03%
=====================================
Files ? 40
Lines ? 8252
Branches ? 0
=====================================
Hits ? 7347
Misses ? 905
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lmiq
changed the title
Contributor
Author
|
@t-bltg maybe can you merge this and release it, to fix precompilation in Juila 1.12-beta1? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to be a quick fix for the precompilation errors in v1.40.12 and Julia 1.12.
It provides the solution presented in https://github.com/JuliaPlots/Plots.jl/actions/runs/14477421381/job/40606364806, but on top of v1.40.12 commit, and bumps the minor version.
If this is merged into a v1.40.13 branch and released, it would be version identical to 1.40.12 but, hopefully, that does not fail on CI runs on Julia 1.12.
It seems that the master branch of Plots is the released branch. In that case it can be merged and released as is.
Attribution
Things to consider