Remove return after error

Author: pedromxavier

ext/QUBOTools_MOI/error.jl

@@ -9,8 +9,6 @@ end
 
 function qubo_parsing_error(msg::AbstractString; ads::Bool = true)
     throw(QUBOParsingError(msg; ads))
-
-    return nothing
 end
 
 function Base.showerror(io::IO, e::QUBOParsingError)

ext/QUBOTools_MOI/model.jl

@@ -55,8 +55,6 @@ function _parse_moi_model(::Type{T}, model::MOI.ModelLike) where {T}
 
     if !_is_unconstrained(model)
         qubo_parsing_error("The provided model is not unconstrained.")
-
-        return nothing
     end
 
     Ω = Set{VI}(MOI.get(model, MOI.ListOfVariableIndices()))
@@ -79,21 +77,15 @@ function _parse_moi_model(::Type{T}, model::MOI.ModelLike) where {T}
     # Assuming: 𝕊, 𝔹 ⊆ Ω
     if !isempty(𝕊) && !isempty(𝔹)
         qubo_parsing_error("The given model contains both boolean and spin variables")
-        
-        return nothing
     elseif isempty(𝕊) # QUBO model?
         if 𝔹 != Ω
             qubo_parsing_error("Not all variables in the given model are boolean")
-
-            return nothing
         else
             return _extract_bool_model(T, model, Ω)
         end
     else # isempty(𝔹) # Ising model?
         if 𝕊 != Ω
             qubo_parsing_error("Not all variables in the given model are spin")
-
-            return nothing
         else
             return _extract_spin_model(T, model, Ω)
         end

ext/QUBOTools_MOI/sense.jl

@@ -5,7 +5,5 @@ function QUBOTools.sense(s::MOI.OptimizationSense)
         return QUBOTools.sense(:max)
     else
         error("Invalid sense for QUBO: '$sense'")
-
-        return nothing
     end
 end

src/library/error.jl

@@ -21,8 +21,6 @@ end
 
 function solution_error(msg::Union{String,Nothing} = nothing)
     throw(SolutionError(msg))
-
-    return nothing
 end
 
 @doc raw"""
@@ -47,8 +45,6 @@ end
 
 function format_error(msg::Union{String,Nothing} = nothing)
     throw(FormatError(msg))
-
-    return nothing
 end
 
 @doc raw"""
@@ -72,8 +68,6 @@ end
 
 function syntax_error(msg::Union{String,Nothing} = nothing)
     throw(SyntaxError(msg))
-
-    return nothing
 end
 
 function syntax_warning(msg::AbstractString)
@@ -103,8 +97,6 @@ end
 
 function casting_error(msg::Union{String,Nothing} = nothing)
     throw(CastingError(msg))
-
-    return nothing
 end
 
 function casting_error((s, t)::Route{X}, ::T) where {X,T}

src/library/form/abstract.jl

@@ -104,15 +104,11 @@ function formtype(spec::Symbol, ::Type{T} = Float64) where {T}
 end
 
 function formtype(::Val{spec}, ::Type = Float64) where {spec}
-    error("Unknown form type specifier '$(spec)'.")
-
-    return nothing
+    error("Unknown form type specifier '$(spec)'")
 end
 
 function formtype(::Type{spec}, ::Type = Float64) where {spec}
-    error("Unknown form type specifier '$(spec)'.")
-
-    return nothing
+    error("Unknown form type specifier '$(spec)'")
 end
 
 

src/library/form/form.jl

@@ -140,7 +140,5 @@ function cast((s, t)::Route{D}, Φ::Form{T,LF,QF}) where {D<:Domain,T,LF<:Abstra
         return Form{T,LF,QF}(n, L, Q, α, β; sense = sense(Φ), domain = t)
     else
         casting_error((s => t), Φ)
-
-        return nothing
     end
 end

src/library/format/bqpjson/format.jl

@@ -10,8 +10,6 @@ function _BQPJSON_VARIABLE_DOMAIN(X::Domain)
         return "spin"
     else
         error("Invalid domain '$X'")
-
-        return nothing
     end
 end
 
@@ -22,8 +20,6 @@ function _BQPJSON_VALIDATE_DOMAIN(x::Integer, X::Domain)
         return (s == ↓) || (s == ↑)
     else
         error("Invalid domain '$X'")
-
-        return nothing
     end
 end
 

src/library/format/qubist/parser.jl

@@ -24,8 +24,6 @@ function _parse_line!(data::Dict{Symbol,Any}, line::AbstractString, fmt::Qubist)
     _parse_header!(data, line, fmt) && return nothing
 
     syntax_error("'$line'")
-
-    return nothing
 end
 
 function _parse_entry!(data::Dict{Symbol,Any}, line::AbstractString, ::Qubist)

src/library/format/qubo/format.jl

@@ -13,9 +13,7 @@ struct QUBO <: AbstractFormat
         elseif style === :mqlib
             return new(:mqlib)
         else
-            error("Unkown style '$style' for QUBO files. Options are: ':dwave', ':qbsolv' and ':mqlib'.")
-
-            return nothing
+            error("Unkown style '$style' for QUBO files. Options are: ':dwave', ':qbsolv' and ':mqlib'")
         end
     end
 end

src/library/format/qubo/parser.jl

@@ -38,8 +38,6 @@ function _parse_line!(data::Dict{Symbol,Any}, line::AbstractString, fmt::QUBO)
     _parse_header!(data, line, fmt, Val(fmt.style)) && return nothing
 
     syntax_error("$line")
-
-    return nothing
 end
 
 function _parse_entry!(

src/library/frame.jl

@@ -7,8 +7,6 @@ function sense(s::Symbol)
         return Max
     else
         error("Invalid sense '$s', options are ':min' and ':max'")
-
-        return nothing
     end
 end
 
@@ -21,8 +19,6 @@ function Base.Symbol(s::Sense)
         return :max
     else
         error("Invalid sense '$s', options are 'Min' and 'Max'")
-
-        return nothing
     end
 end
 
@@ -37,8 +33,6 @@ function domain(x::Symbol)
         return SpinDomain
     else
         error("Invalid domain '$x', options are ':bool' and ':spin'")
-
-        return nothing
     end
 end
 
@@ -51,8 +45,6 @@ function Base.Symbol(x::Domain)
         return :spin
     else
         error("Invalid domain '$x', options are 'BoolDomain' and 'SpinDomain'")
-
-        return nothing
     end
 end
 

src/library/model/abstract.jl

@@ -21,8 +21,6 @@ function variable(model::AbstractModel{V}, i::Integer) where {V}
         return mapping[i]
     else
         error("Variable with index '$i' does not belong to the model")
-
-        return nothing
     end
 end
 

src/library/model/model.jl

@@ -183,8 +183,6 @@ function index(model::Model{V}, v::V) where {V}
         return index(model.variable_map, v)
     else
         error("Variable '$v' does not belong to the model")
-
-        return nothing
     end
 end
 
@@ -208,8 +206,6 @@ solution(model::Model) = model.solution
 function start(model::Model{V,T,U}, i::Integer; domain = QUBOTools.domain(model)) where {V,T,U}
     if !hasindex(model, i)
         error("Index '$i' is out of bounds [1, $(dimension(model))]")
-
-        return nothing
     elseif haskey(model.start, i)
         return cast((QUBOTools.domain(model) => QUBOTools.domain(domain)), model.start[i])
     else

src/library/model/variable_map.jl

@@ -35,8 +35,6 @@ function index(vm::VariableMap{V}, v::V) where {V}
         return vm.map[v]
     else
         error("Variable '$v' does not belong to the mapping")
-
-        return nothing
     end
 end
 
@@ -47,7 +45,5 @@ function variable(vm::VariableMap, i::Integer)
         return vm.inv[i]
     else
         error("Variable index '$i' is out of range '[1, $n]'")
-
-        return nothing
     end
 end

src/library/solution/abstract.jl

@@ -38,8 +38,6 @@ function sample(sol::AbstractSolution, i::Integer)
         return getindex(sol, i)
     else
         error("Sample with index '$i' does not belong to the solution")
-
-        return nothing
     end
 end
 

src/library/solution/sampleset.jl

@@ -132,7 +132,5 @@ function cast((s,t)::Route{D}, sol::SampleSet{T,U}) where {T,U,D<:Domain}
         )
     else
         casting_error(s => t, sol)
-
-        return nothing
     end
 end