Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] The ability to tell CompatHelper "please don't open this PR for another X days" #328

Open
DilumAluthge opened this issue Jun 2, 2021 · 1 comment

Comments

@DilumAluthge
Copy link
Member

We should have the ability for users to tell CompatHelper "please don't open this PR for another X days", where X ≥ 1. The user should be able to specify the value of X. If X is unspecified, we can default to something like X = 30.

@marius311
Copy link

marius311 commented Jun 2, 2021

Thanks for the reply in the other thread. That example seems fair to me, but IMO is the less likely scenario as compared to just that I want to close a CompatHelper PR forever since I'm working on the upgrade myself separately. Viewing the latter case as the more typical one (which is certainly up for debate), then I would say it makes more sense if the default is for CompatHelper to not reopen identical PRs, and instead provide the user a way to manually reopen closed ones, probably by commenting "reopen" or something on the original (closed) PR. Just my 2c based on my experience / workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants