Conversation
JuliaRegistrator
commented
Dec 3, 2024
- Registering package: JiL
- Repository: https://github.com/aptmcl/JiL.jl
- Created by: @aptmcl
- Version: v0.1.0
- Commit: 7b1030b079d7f1b8976acb428921607b6e138f47
- Reviewed by: @aptmcl
- Reference: aptmcl/JiL.jl@7b1030b#commitcomment-149868785
- Description: The JiL programming language: a Lisp dialect on top of Julia.
UUID: 20193457-2d4f-441d-9a0a-984def152164 Repo: https://github.com/aptmcl/JiL.jl.git Tree: 9085e4268f60b449fb0cf7ce2c9957695a05f408 Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
|
Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human. 1. New package registrationPlease make sure that you have read the package naming guidelines. 2. AutoMerge Guidelines which are not met ❌
3. Needs action: here's what to do next
If you need help fixing the AutoMerge issues, or want your pull request to be manually merged instead, please post a comment explaining what you need help with or why you would like this pull request to be manually merged. Then, send a message to the 4. To pause or stop registrationIf you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text Tip: You can edit blocking comments to add |
|
For this type of package, I think a name like |
|
I'm not sure I understand what is being requested from me. Are you saying that either I change the name of the package to something that has five characters or else I need to ask a registry maintainer to manually merge it? I rather prefer the second option, so can you tell me the proper way to contact a registry maintainer? |
|
Yes, that is correct. As the bot message indicates, you have to post on the |
|
If I understand this package correctly, during initialization, it globally replaces the runtime-wide parser with a new parser that tries to figure out if a piece of code looks lispy, and if it is lispy, it parses using a lisp parser and if not, it'll use julia's parser. I must say that even as a lisp enthusiast, this makes me pretty uncomfortable and I don't think this is something that a package in the general registry should be doing, as this behaviour can have profoundly far reaching implications. I'd be much more comfortable if instead you had a As it is currently, simply |
|
I understand your discomfort and, clearly, this package is an experiment on making Julia more like Racket, not only in the use of fully-parenthesized prefix syntax, but also in the support for program files written in different syntaxes, including the original Julia syntax. Those who will use it should expect the parser to change, hopefully, in a backwards-compatible way. I don't know what is expected from me at this moment. Can you tell me which of the following is needed for the package to be registered?
Thanks in advance. |
What I mean though is that since you're calling
Sorry, I should have been more clear. I am also not a registry maintainer and I don't have the rights to approve or deny your package. I am just giving my feedback as to why I am a bit uncomfortable with the implementation itself so that you can consider that feedback, and so that whichever registry maintainer ends up looking at this knows about that extra context (i.e. that this is potentially not just a naming issue). That said, we usually don't block packages from registration just because they're doing something that a rando like me thinks is a bad idea. I just thought I'd flag it just in case it is important. Separately, I should also say this is a really cool package and I love to see people playing around with this stuff! It's very neat, (I'm just not totally sure it is a good fit for the general registry -- but I'm also not convinced it shouldnt be registed) |
|
This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock] |
|
This pull request has been inactive for more than 30 days and has automatically been closed. Feel free to register your package or version again once you fix the AutoMerge issues. [noblock] |