Skip to content

Add explicit compat bounds for the Distributed stdlib#121256

Closed
JamesWrigley wants to merge 2 commits intoJuliaRegistries:masterfrom
JamesWrigley:distributed-compat
Closed

Add explicit compat bounds for the Distributed stdlib#121256
JamesWrigley wants to merge 2 commits intoJuliaRegistries:masterfrom
JamesWrigley:distributed-compat

Conversation

@JamesWrigley
Copy link
Contributor

Unfortunately this also includes a bunch of extraneous whitespace changes. In total there are 512 affected packages.

I believe all the previous steps have already been done: JuliaLang/julia#50697
Requires this PR to reproduce: KristofferC/StdlibRegistryCompatUpdater#2

CC @vchuravy

@KristofferC
Copy link
Member

Would it be possible to have a PR that first normalizes all the whitespace in the registry (which would be easy to review) and then have this on top of it so that it wouldn't mix actual changes with whitespace only?

@JamesWrigley
Copy link
Contributor Author

I can make the PR but you'll have to merge it pretty quickly to avoid merge conflicts 😛

@fredrikekre
Copy link
Member

I thought there were tests that verify that files roundtrip after parsing and rewriting. Perhaps we are just testing that the parsed output is equal to the parsed-written-reparsed output?

Is this a change in TOML.jl?

@KristofferC
Copy link
Member

KristofferC commented Dec 13, 2024

Hm, the changes here seems to undo #65999.

I thought there were tests that verify that files roundtrip after parsing and rewriting

JuliaRegistries/RegistryCI.jl#459 doesn't seem closed

@JamesWrigley
Copy link
Contributor Author

Is there like a preference for formatting that I'm missing or something?

@JamesWrigley
Copy link
Contributor Author

Running the stdlib updater on 1.10 seems to have removed the whitespace changes, but now there's 500 modified files instead of 512 🤔

@JamesWrigley
Copy link
Contributor Author

These are the packages that were skipped when running in 1.10:

julia> setdiff(dot_11, dot_10)
12-element Vector{SubString{String}}:
 "BLAKJac"
 "ClimaCalibrate"
 "CloudClusters"
 "EwaldSummations"
 "GeoStatsProcesses"
 "LibraryAugmentedSymbolicRegression"
 "OpenGeoSysUncertaintyQuantification"
 "Oscar"
 "ParametricProcesses"
 "PulseInputDDM"
 "TableTransforms"
 "TopologicalNumbers"

They all already have compat bounds and the difference between the diffs looks to be purely whitespace changes, e.g.:

modified   P/ParametricProcesses/Compat.toml
@@ -1,3 +1,3 @@
 [0]
-Distributed = "1.9.2-1"
-julia = "1.5.0-1"
+Distributed = "1.9.2 - 1"
+julia = "1.5.0 - 1"

So I think the new diff from 1.10 can be trusted.

@JamesWrigley
Copy link
Contributor Author

I realized this didn't actually have a package directory for Distributed, added it in 3cf4618. Does anyone know how to test it? When I put the clone in ~/.julia/registries/General Julia doesn't seem to like it:

 Error: Some registries failed to update:                                                                                                                                                                                                     
│     — `~/.julia/registries/General` — registry dirty                                                                                                                                                                                         
└ @ Pkg.Registry ~/.julia/juliaup/julia-1.11.2+0.x64.linux.gnu/share/julia/stdlib/v1.11/Pkg/src/Registry/Registry.jl:546  

(this is with all changes committed)

@github-actions
Copy link
Contributor

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label Jan 18, 2025
@JamesWrigley
Copy link
Contributor Author

Rebased to fix merge conflicts. I believe this is ready for review.

@github-actions github-actions bot removed the stale label Jan 19, 2025
@github-actions
Copy link
Contributor

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label Feb 18, 2025
@github-actions
Copy link
Contributor

This pull request has been inactive for more than 30 days and has automatically been closed. Feel free to register your package or version again once you fix the AutoMerge issues. [noblock]

@github-actions github-actions bot closed this Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants