Skip to content

Restrict StaticArrays.jl @v1.5.16- to Julia v1.10-#121870

Closed
fhagemann wants to merge 1 commit intoJuliaRegistries:masterfrom
fhagemann:patch-1
Closed

Restrict StaticArrays.jl @v1.5.16- to Julia v1.10-#121870
fhagemann wants to merge 1 commit intoJuliaRegistries:masterfrom
fhagemann:patch-1

Conversation

@fhagemann
Copy link
Contributor

Repeating #116935 :

Following up on #86950 (comment):
In #86950, the julia compat was restricted to ≤ 1.10 for StaticArrays@1-1.5.
However, the code which errors was only removed in 1.5.17, see here.

This change was already merged in #116935, but reverted in #117626 because of tests failing in Pkg.jl (which were pulling StaticArrays@1.5.0).

I proposed a change in the Pkg tests in JuliaLang/Pkg.jl#4077, where now StaticArrays@1.5.20 is pulled instead of StaticArrays@1.5.0.

Now, remerging #116935 should be fine.

@github-actions
Copy link
Contributor

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label Jan 22, 2025
@fhagemann
Copy link
Contributor Author

Maybe someone could have a look at this. This PR was originally approved, reverted because it was breaking the Pkg tests. But the Pkg tests have been fixed in the mean time.

@github-actions github-actions bot removed the stale label Jan 23, 2025
@fhagemann
Copy link
Contributor Author

@carstenbauer @giordano 😇

@github-actions
Copy link
Contributor

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

@github-actions github-actions bot added the stale label Mar 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

This pull request has been inactive for more than 30 days and has automatically been closed. Feel free to register your package or version again once you fix the AutoMerge issues. [noblock]

@github-actions github-actions bot closed this Apr 1, 2025
DilumAluthge pushed a commit that referenced this pull request Oct 11, 2025
I'm gonna try this again (based on #121870 and #116935 ):


> Following up on [#86950
(comment)](#86950 (comment)):
> In #86950, the julia compat was restricted to ≤ 1.10 for
StaticArrays@1-1.5.
> However, the code which errors was only removed in 1.5.17, see
[here](JuliaArrays/StaticArrays.jl@fdf3530).

This change was already merged in #116935, but reverted in #117626
because of tests failing in Pkg.jl (which were pulling
`StaticArrays@1.5.0`).

I proposed a change in the Pkg tests in
[JuliaLang/Pkg.jl#4077](JuliaLang/Pkg.jl#4077),
where now `StaticArrays@1.5.20` is pulled instead of
`StaticArrays@1.5.0`.

Now, remerging #116935 (which are the changes in this PR) should be
fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant