Conversation
|
Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human. 1. New package registrationPlease make sure that you have read the package naming guidelines. 2. AutoMerge Guidelines are all met! ✅Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. 3. To pause or stop registrationIf you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text Tip: You can edit blocking comments to add |
|
I have fixed the missing compat entry and added the LICENSE file. Regarding the name similarity warning: Momenta.jl is a package for Econometrics (GMM/PVAR analysis), whereas Memento.jl is a logging library. They operate in completely different domains and serve different purposes. Please manually merge this registration. |
28002f8 to
c823e34
Compare
|
[noblock] |
c823e34 to
d8ab046
Compare
|
[noblock] |
d8ab046 to
eb93e22
Compare
|
[noblock] |
|
All comments have to contain |
|
Could you add some tests (with coverage tracking) that run through in GitHub actions before registering? In particular, please make sure it is possible to run the "quick start" example in the README (provide the file Given the presence of emojis in the README, I just want to make sure that you're aware of the LLM guidelines for the General registry |
UUID: 0ca3efaa-fb53-4d2f-87c7-6a9f57d6cfab Repo: https://github.com/dazhwu/Momenta.jl.git Tree: 475c34f9e531c9d7f9b5a88efb40965676e285f0 Registrator tree SHA: 50f504d641745716a5b3eabaf681d3a4937d2ae3
eb93e22 to
43b0bb0
Compare
|
[noblock] |
|
Thanks for the review. I've added the missing dataset (dahlberg_data.csv) and a corresponding test case in runtests.jl that executes the Quick Start example. I've cleaned up the README (removed excessive emojis) and set up GitHub Actions for CI/Coverage. The tests are passing locally and on CI. I have triggered the registration again. Please let me know if there is anything else. |
|
Thanks for the review.
1.
I've added the missing dataset (dahlberg_data.csv) and a corresponding test case in runtests.jl that executes the Quick Start example.
2.
I've cleaned up the README (removed excessive emojis) and set up GitHub Actions for CI/Coverage.
3.
The tests are passing locally and on CI. I have triggered the registration again.
Please let me know if there is anything else.
…________________________________
From: Michael Goerz ***@***.***>
Sent: Tuesday, December 23, 2025 6:07 AM
To: JuliaRegistries/General ***@***.***>
Cc: Wu, Dazhong ***@***.***>; Mention ***@***.***>
Subject: [EXTERNAL] Re: [JuliaRegistries/General] New package: Momenta v0.0.1 (PR #144854)
EXTERNAL: This email was sent to you from an external source. Please review the content carefully and open attachments or click links only if you recognize the sender.
[https://avatars.githubusercontent.com/u/112306?s=20&v=4]goerz left a comment (JuliaRegistries/General#144854)<#144854 (comment)>
Could you add some tests (with coverage tracking) that run through in GitHub actions before registering? In particular, please make sure it is possible to run the "quick start" example in the README (provide the file dahlberg_data.csv).
Given the presence of emojis in the README, I just want to make sure that you're aware of the LLM guidelines for the General registry<https://github.com/JuliaRegistries/General?tab=readme-ov-file#is-there-any-policy-regarding-the-use-of-llms-in-registered-packages>
—
Reply to this email directly, view it on GitHub<#144854 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APCQS2IPB7IROLHZ7I4QAVL4DEO5XAVCNFSM6AAAAACPU4AGQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMOBWGIYTEMJUGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Uh oh!
There was an error while loading. Please reload this page.