Fix example in ReadMe #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
- Coverage 74.08% 73.88% -0.21%
==========================================
Files 17 17
Lines 822 831 +9
==========================================
+ Hits 609 614 +5
- Misses 213 217 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jeremiahpslewis
approved these changes
Apr 4, 2025
jeremiahpslewis
merged commit 8af5015
into
JuliaReinforcementLearning:main
3 of 5 checks passed
|
thanks for the fast merge @jeremiahpslewis! Having the first push! different from the rest seems a bit ackward, is it sensible to make the code work as was intended by the previous syntax in the readme? If so, I could try to work on that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example didn't work before, I tried to make it work and I took the liberty to slightly change the formatting. Let me know if the intended behaviour was the other one (which currently throws when pushing) because I would be happy to try to go in that direction with another PR if desirable.