Skip to content

Commit 1cf8349

Browse files
authored
🐛 Bound Tau Hour Angle in JR1971 (#8)
1 parent 3ec72fd commit 1cf8349

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

src/jr1971/jr1971.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ function jr1971(
234234

235235
# Eq. 16 [2], Section B.1.1 [3]
236236

237-
τ = H + deg2rad(-37 + 6sin(H + deg2rad(43)))
237+
τ = rem2pi(H + deg2rad(-37 + 6sin(H + deg2rad(43))), RoundNearest)
238238

239239
# Eq. 17 [2], Section B.1.1 [3]
240240

test/differentiablity.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ end
7878

7979
# Include something() to replace Zygote "nothing" with 0.0
8080
@test f_fd f_ad atol=1e-10
81-
@test df_fd something.(df_ad, 0) rtol=2e-1
81+
@test df_fd something.(df_ad, 0) atol=5e-1
8282

8383
f_ad2, df_ad2 = value_and_gradient(
8484
(x) -> AtmosphericModels.jr1971(x...; verbose=Val(false)).total_density,
@@ -88,7 +88,7 @@ end
8888

8989
# Include something() to replace Zygote "nothing" with 0.0
9090
@test f_fd2 f_ad2 atol = 1e-10
91-
@test df_fd2 something.(df_ad2, 0) rtol=2e-1
91+
@test df_fd2 something.(df_ad2, 0) rtol=5e-1
9292

9393
end
9494
end

test/jr1971.jl

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -259,16 +259,16 @@ end
259259
str = sprint(show, result)
260260

261261
expected = """
262-
Jacchia-Roberts 1971 Atmospheric Model Result:
263-
Total density : 5.15927e-14 kg / m³
264-
Temperature : 679.39 K
265-
Exospheric Temp. : 679.44 K
266-
N₂ number density : 1.47999e+09 1 / m³
267-
O₂ number density : 1.50981e+07 1 / m³
268-
O number density : 1.58322e+12 1 / m³
269-
Ar number density : 2149.38 1 / m³
270-
He number density : 1.42329e+12 1 / m³
271-
H number density : 0 1 / m³"""
262+
Jacchia-Roberts 1971 Atmospheric Model Result:
263+
Total density : 3.63066e-13 kg / m³
264+
Temperature : 907.60 K
265+
Exospheric Temp. : 907.92 K
266+
N₂ number density : 7.30485e+10 1 / m³
267+
O₂ number density : 1.35105e+09 1 / m³
268+
O number density : 1.29933e+13 1 / m³
269+
Ar number density : 630285 1 / m³
270+
He number density : 2.16503e+12 1 / m³
271+
H number density : 0 1 / m³"""
272272

273273
str = sprint(show, MIME("text/plain"), result)
274274
@test str == expected

0 commit comments

Comments
 (0)