perf: replace offset helper functions with OffsetsIterator type#36
Merged
perf: replace offset helper functions with OffsetsIterator type#36
Conversation
Member
Beforerr
commented
Feb 3, 2026
Beforerr
commented
- Introduced OffsetsIterator struct to encapsulate offset traversal logic
- Replaced get_offsets, get_offsets!, and get_offsets_lazy with iterator-based approach
- Changed cdf_magic_bytes from Vector to Tuple for immutability
- Optimized attribute name comparison using codeunits instead of String conversion
Beforerr
force-pushed
the
push-ynsrqvlmvkvl
branch
from
34af43b to
651683a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- Introduced OffsetsIterator struct to encapsulate offset traversal logic - Replaced get_offsets, get_offsets!, and get_offsets_lazy with iterator-based approach - Changed cdf_magic_bytes from Vector to Tuple for immutability - Optimized attribute name comparison using codeunits instead of String conversion
Beforerr
force-pushed
the
push-ynsrqvlmvkvl
branch
from
651683a to
d650757
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.