Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Beforerr
force-pushed
the
push-syvnwsqplnqp
branch
2 times, most recently
from
5cb32dc to
8643b0d
Compare
Beforerr
force-pushed
the
push-syvnwsqplnqp
branch
3 times, most recently
from
56f5c93 to
8c35dc8
Compare
… KappaPDF, BiMaxwellianPDF, BiKappaPDF) - Add ShiftedPDF wrapper for representing drifted distributions - Add CHANGELOG.md documenting breaking changes to drift velocity handling - Add public constructors (Maxwellian, Kappa, BiMaxwellian, BiKappa) that support optional u0 keyword argument - Support density parameter n as first argument in public constructors, returning VelocityDistribution
Beforerr
force-pushed
the
push-syvnwsqplnqp
branch
from
8c35dc8 to
f6fce97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main motivation for this change is to avoid duplicating drift logic across each PDF type and with non-zero drift velocity, speed distributions are no longer invariant to translations (not have simple analytic form any more)