Skip to content

Separate sym factor 2#32

Merged
rayegun merged 2 commits into
JuliaSparse:mainfrom
luke-kiernan:separate-sym-factor-rebase
Mar 21, 2026
Merged

Separate sym factor 2#32
rayegun merged 2 commits into
JuliaSparse:mainfrom
luke-kiernan:separate-sym-factor-rebase

Conversation

@luke-kiernan
Copy link
Copy Markdown
Contributor

PR #28, but rebased to remove the commit where I did those eval-to-multiple-dispatch changes.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 55.92%. Comparing base (ac026c4) to head (817a608).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/KLU.jl 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   55.24%   55.92%   +0.67%     
==========================================
  Files           2        2              
  Lines         572      574       +2     
==========================================
+ Hits          316      321       +5     
+ Misses        256      253       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah
Copy link
Copy Markdown
Member

@rayegun good to merge?

@ViralBShah
Copy link
Copy Markdown
Member

@luke-kiernan would it be helpful for you to have commit here?

@rayegun rayegun merged commit 95825f6 into JuliaSparse:main Mar 21, 2026
8 of 9 checks passed
@luke-kiernan luke-kiernan deleted the separate-sym-factor-rebase branch March 21, 2026 16:45
@ViralBShah
Copy link
Copy Markdown
Member

@rayegun Should we release 0.6.1 or should it be 0.7.0? Easy enough to trigger the registrator here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants