Skip to content

unwrap all args to + and *#1876

Merged
AayushSabharwal merged 1 commit into
JuliaSymbolics:masterfrom
KristofferC:kc/unwrap
Jun 2, 2026
Merged

unwrap all args to + and *#1876
AayushSabharwal merged 1 commit into
JuliaSymbolics:masterfrom
KristofferC:kc/unwrap

Conversation

@KristofferC

Copy link
Copy Markdown
Contributor

Otherwise this seems inconsistent with - and /, where both first and second argument is unwrapped and it also becomes weird that a * b calls MulWorkerBuffer with the first argument BasicSymbolicImpl and the second Num

Otherwise this seems inconsistent with `-` where both first and second argument is unwrapped and it also becomes weird that `a * b` calls `MulWorkerBuffer` with the first argument `BasicSymbolicImpl` and the second `Num`
@codecov-commenter

codecov-commenter commented May 28, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 5.38%. Comparing base (c736678) to head (4e21400).
⚠️ Report is 105 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

❗ There is a different number of reports uploaded between BASE (c736678) and HEAD (4e21400). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (c736678) HEAD (4e21400)
6 3
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #1876       +/-   ##
==========================================
- Coverage   26.12%   5.38%   -20.74%     
==========================================
  Files          56      57        +1     
  Lines        5356    5574      +218     
==========================================
- Hits         1399     300     -1099     
- Misses       3957    5274     +1317     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AayushSabharwal AayushSabharwal merged commit b51d71b into JuliaSymbolics:master Jun 2, 2026
19 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants