CompatHelper: bump compat for Optimisers to 0.4, (keep existing compat)#130
CompatHelper: bump compat for Optimisers to 0.4, (keep existing compat)#130github-actions[bot] wants to merge 2 commits intomainfrom
Conversation
e7c14d3 to
45065b3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
=======================================
Coverage 97.00% 97.00%
=======================================
Files 22 22
Lines 734 734
=======================================
Hits 712 712
Misses 22 22 ☔ View full report in Codecov by Sentry. |
|
This CI run is very old. Optimisers.jl does need the update here, but the error thrown here doesn't seem to apply to the code at master, which looks, as far as I can tell, compliant with latest Optimisers.jl API despite the complaint in the CI log. @pat-alt Can you please retrigger CI or otherwise investigate a compat update of Optimisers.jl to 0.4? The current restriction is blocking use of LaplaceRedux with some other MLJ models using Flux, possibly MLJFlux. If you already have this on the radar, my apologies. |
|
Also, CompatHelper appears to be dormant. |
|
Thanks @ablaom. I've started working on this in #144 but I'm afraid there are some parts of the code that need to be updated. I hope to get it done early next week, but I still have limited bandwidth because I'm caught up in thesis-related work at the moment. I hope this is not blocking any other packages or functionality. Feel free to ping me again though if we're holding things up on some other end. @pasq-cat tagging you in case you might be able to check #144 |
|
@pat-alt uhm i can try in the weekend. |
|
Closed by #146 |
|
Now closed by #147 |
This pull request changes the compat entry for the
Optimiserspackage from0.2, 0.3to0.2, 0.3, 0.4.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.