Skip to content

CompatHelper: bump compat for Optimisers to 0.4, (keep existing compat)#130

Closed
github-actions[bot] wants to merge 2 commits intomainfrom
compathelper/new_version/2024-11-08-00-47-29-951-00560940772
Closed

CompatHelper: bump compat for Optimisers to 0.4, (keep existing compat)#130
github-actions[bot] wants to merge 2 commits intomainfrom
compathelper/new_version/2024-11-08-00-47-29-951-00560940772

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 8, 2024

This pull request changes the compat entry for the Optimisers package from 0.2, 0.3 to 0.2, 0.3, 0.4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@pat-alt pat-alt force-pushed the compathelper/new_version/2024-11-08-00-47-29-951-00560940772 branch from e7c14d3 to 45065b3 Compare November 8, 2024 00:47
@codecov
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.00%. Comparing base (5f66429) to head (45065b3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   97.00%   97.00%           
=======================================
  Files          22       22           
  Lines         734      734           
=======================================
  Hits          712      712           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ablaom
Copy link
Contributor

ablaom commented Jan 22, 2026

This CI run is very old. Optimisers.jl does need the update here, but the error thrown here doesn't seem to apply to the code at master, which looks, as far as I can tell, compliant with latest Optimisers.jl API despite the complaint in the CI log.

@pat-alt Can you please retrigger CI or otherwise investigate a compat update of Optimisers.jl to 0.4?

The current restriction is blocking use of LaplaceRedux with some other MLJ models using Flux, possibly MLJFlux.

If you already have this on the radar, my apologies.

@ablaom
Copy link
Contributor

ablaom commented Jan 22, 2026

Also, CompatHelper appears to be dormant.

@pat-alt
Copy link
Member

pat-alt commented Jan 23, 2026

Thanks @ablaom. I've started working on this in #144 but I'm afraid there are some parts of the code that need to be updated. I hope to get it done early next week, but I still have limited bandwidth because I'm caught up in thesis-related work at the moment. I hope this is not blocking any other packages or functionality. Feel free to ping me again though if we're holding things up on some other end.

@pasq-cat tagging you in case you might be able to check #144

@pasq-cat
Copy link
Member

@pat-alt uhm i can try in the weekend.

@pat-alt
Copy link
Member

pat-alt commented Feb 5, 2026

Closed by #146

@pat-alt pat-alt closed this Feb 5, 2026
@pat-alt pat-alt reopened this Feb 5, 2026
@pat-alt
Copy link
Member

pat-alt commented Feb 5, 2026

Now closed by #147

@pat-alt pat-alt closed this Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants