Merge pull request #224 from JulianHayward/mssgck

6.4.0

Author: JulianHayward

.azuredevops/pipelines/AzGovViz.pipeline.yml

@@ -20,7 +20,7 @@ schedules:
     - master #CHECK branch 'master' is applicable? - delete me :)
 
 #Running AzOps? Run Azure Governance Visualizer after 'AzOps - Push' ..
-#AzOps Accellerator https://github.com/Azure/AzOps-Accelerator
+#AzOps accelerator https://github.com/Azure/AzOps-Accelerator
 #resources:
 #  pipelines:
 #    - pipeline: 'Push'
@@ -188,7 +188,7 @@ jobs:
         }
         else {
             Write-Host "Assuming and insisting that you do not want to publish your tenant insights to the public"
-            Write-Host "HTML NOT published. Please configure authentication on the webApp ($($env:WEBAPPNAME))"
+            Write-Host "HTML NOT published. Please configure authentication on the Azure Web App ($($env:WEBAPPNAME))."
             exit 1
         }
       azurePowerShellVersion: latestVersion

.azuredevops/pipelines/AzGovViz.variables.yml

@@ -117,12 +117,12 @@ variables:
     # String | example: value: "westus"
     value: 'westeurope'
 
-  # Defines the limit (default=500) of AAD Group members; For AAD Groups that have more members than the defined limit Group members will not be resolved
+  # Defines the limit (default=500) of Microsoft Entra group members; For Microsoft Entra groups that have more members than the defined limit, group members will not be resolved
   - name: AADGroupMembersLimit
     # Integer | default = 500 | example: value: 333
     value:
 
-  # Define warning period for Service Principal secret and certificate expiry
+  # Define warning period for the service principal secret and certificate expiry
   - name: AADServicePrincipalExpiryWarningDays
     # Integer | default = 14 | example: value: 21
     value:
@@ -207,7 +207,7 @@ variables:
     # Switch | example: value: true
     value:
 
-  # Will not resolve Microsoft Entra ID (AAD) Group memberships for Role assignments where identity type is 'Group'
+  # Will not resolve Microsoft Entra group memberships for role assignments where identity type is 'Group'
   - name: NoAADGroupsResolveMembers
     # Switch | example: value: true
     value:
@@ -276,7 +276,7 @@ variables:
     # Switch | example: value: true
     value:
 
-  # Define the number of script blocks running in parallel. Leveraging PowerShell Core´s parallel capability you can define the ThrottleLimit (default=5)
+  # Define the number of script blocks running in parallel. Using PowerShell's parallel capability you can define the ThrottleLimit (default=5).
   - name: ThrottleLimit
     # Integer | Default = 10 | example: value: 11
     value:

.github/workflows/AzGovViz.yml

@@ -135,7 +135,7 @@ jobs:
             }
             else {
               Write-Host 'Assuming and insisting that you do not want to publish your tenant insights to the public'
-              Write-Host "HTML NOT published. Please configure authentication on the webApp ($($env:WebAppName))"
+              Write-Host "HTML NOT published. Please configure authentication on the Azure Web App ($($env:WebAppName))."
               exit 1
             }
           azPSVersion: "latest"

.github/workflows/AzGovViz_OIDC.yml

@@ -144,7 +144,7 @@ jobs:
             }
             else {
               Write-Host 'Assuming and insisting that you do not want to publish your tenant insights to the public'
-              Write-Host "HTML NOT published. Please configure authentication on the webApp ($($env:WebAppName))"
+              Write-Host "HTML NOT published. Please configure authentication on the Azure Web App ($($env:WebAppName))."
               exit 1
             }
           azPSVersion: "latest"

README.md

@@ -1,18 +1,18 @@
-# Contribution Guide
+# Contribution guide
 
-* Fork the repository
-* Your working directory is `.\Azure-MG-Sub-Governance-Reporting`
-    * In the folder `.\pwsh\dev` find the function you intend to work on, apply your changes
-    * Edit the file `.\pwsh\dev\devAzGovVizParallel.ps1`
-        * In the param block update the parameter variable `$ProductVersion` accordingly
-    * Execute `.\pwsh\dev\buildAzGovVizParallel.ps1` - This step will rebuilt the main `.\pwsh\AzGovVizParallel.ps1` file (incorporating all changes you did in the `.\pwsh\dev` directory)
-    * Edit the file `.\README.md`
-        * Update the region `Release history`, replace the changes from the previous release with your changes
-    * Edit the file `.\history.md`
-        * Copy over text for the change description you just did for the `.\README.md`
-    * Execute the newly created AzGovViz version to test if it completes successfully  
-     `.\pwsh\AzGovVizParallel.ps1 -ShowRunIdentifier`  
-     From the very last line of the output take a copy of the __run identifier__ and provide that with the pull request
-* Commit your changes
-* Create a pull request
-    * Provide the __run identifier__ in the pull request as a proof of successful test
+1. Fork the repository.
+1. Change you working directory to `.\Azure-MG-Sub-Governance-Reporting`.
+1. In the folder `.\pwsh\dev` find the function you intend to work on and apply your changes.
+1. Edit the file `.\pwsh\dev\devAzGovVizParallel.ps1`.
+   - In the param block update the parameter variable `$ProductVersion` accordingly.
+   - Note: Do not change anything else in this file if you did not introduce new functions!
+1. Execute `.\pwsh\dev\buildAzGovVizParallel.ps1` - This step will rebuilt the main `.\pwsh\AzGovVizParallel.ps1` file, incorporating all changes you did in the `.\pwsh\dev` directory.
+1. Edit the file `.\README.md`.
+   - Update the region `Release history`, replace the changes from the previous release with your changes.
+1. Edit the file `.\history.md`.
+   - Copy over text for the change description you just did for the `.\README.md`.
+1. Execute the newly created AzGovViz version to test if it completes successfully by running `.\pwsh\AzGovVizParallel.ps1 -ShowRunIdentifier`.
+   - From the very last line of the output copy the __run identifier__, you'll need that when you open your pull request.
+1. Commit your changes.
+1. Create a pull request
+   - Provide the __run identifier__ in the pull request as a proof of successful test