test: fix caveman-init counts, isolate openclaw ws

Counts were stale after the opencode + openclaw targets landed (5 -> 6
repo files, 7 with the openclaw line). Tests also ran the openclaw
installer against the developer's real ~/.openclaw/workspace; runInit()
now pins OPENCLAW_WORKSPACE inside the fixture tmp dir so nothing
escapes the sandbox. verify_repo.py drops the removed
.agents/plugins/marketplace.json from its manifest list.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: JuliusBrussee

tests/test_caveman_init.js

@@ -14,6 +14,16 @@ const INIT = path.join(ROOT, 'src', 'tools', 'caveman-init.js');
 let passed = 0;
 let failed = 0;
 
+// Point OPENCLAW_WORKSPACE at a nonexistent dir inside the fixture so the
+// openclaw target reports skipped-workspace-missing instead of writing to
+// the developer's real ~/.openclaw/workspace.
+function runInit(tmp, ...args) {
+  return execFileSync(process.execPath, [INIT, tmp, ...args], {
+    encoding: 'utf8',
+    env: { ...process.env, OPENCLAW_WORKSPACE: path.join(tmp, 'no-openclaw') },
+  });
+}
+
 function test(name, fn) {
   const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'caveman-init-test-'));
   try {
@@ -31,7 +41,7 @@ function test(name, fn) {
 console.log('caveman-init tests\n');
 
 test('greenfield: creates all rule files with proper frontmatter', (tmp) => {
-  execFileSync(process.execPath, [INIT, tmp], { encoding: 'utf8' });
+  runInit(tmp);
   const cursor = fs.readFileSync(path.join(tmp, '.cursor/rules/caveman.mdc'), 'utf8');
   assert.match(cursor, /alwaysApply: true/);
   assert.match(cursor, /Respond terse like smart caveman/);
@@ -43,18 +53,21 @@ test('greenfield: creates all rule files with proper frontmatter', (tmp) => {
   assert.match(copilot, /Respond terse/);
   const agents = fs.readFileSync(path.join(tmp, 'AGENTS.md'), 'utf8');
   assert.match(agents, /Respond terse/);
+  const opencode = fs.readFileSync(path.join(tmp, '.opencode/AGENTS.md'), 'utf8');
+  assert.match(opencode, /Respond terse/);
 });
 
 test('idempotent: re-running on a clean install skips all', (tmp) => {
-  execFileSync(process.execPath, [INIT, tmp], { encoding: 'utf8' });
-  const out = execFileSync(process.execPath, [INIT, tmp], { encoding: 'utf8' });
-  assert.match(out, /5 skipped/);
+  runInit(tmp);
+  const out = runInit(tmp);
+  // 6 repo rule files skipped-already-installed + openclaw skipped (no workspace)
+  assert.match(out, /7 skipped/);
   assert.doesNotMatch(out, /[1-9]\d* added/);
 });
 
 test('append mode: existing AGENTS.md gets caveman appended (not replaced)', (tmp) => {
   fs.writeFileSync(path.join(tmp, 'AGENTS.md'), '# My project\n\nDo not delete me.\n');
-  execFileSync(process.execPath, [INIT, tmp], { encoding: 'utf8' });
+  runInit(tmp);
   const agents = fs.readFileSync(path.join(tmp, 'AGENTS.md'), 'utf8');
   assert.match(agents, /Do not delete me/);
   assert.match(agents, /Respond terse like smart caveman/);
@@ -64,7 +77,7 @@ test('skip mode: existing .cursor rule is not overwritten without --force', (tmp
   const dir = path.join(tmp, '.cursor/rules');
   fs.mkdirSync(dir, { recursive: true });
   fs.writeFileSync(path.join(dir, 'caveman.mdc'), '# original\nDo not delete me.\n');
-  const out = execFileSync(process.execPath, [INIT, tmp], { encoding: 'utf8' });
+  const out = runInit(tmp);
   assert.match(out, /\? .*\.cursor\/rules\/caveman\.mdc/);
   const after = fs.readFileSync(path.join(dir, 'caveman.mdc'), 'utf8');
   assert.strictEqual(after, '# original\nDo not delete me.\n');
@@ -74,25 +87,26 @@ test('--force overwrites existing rule files', (tmp) => {
   const dir = path.join(tmp, '.cursor/rules');
   fs.mkdirSync(dir, { recursive: true });
   fs.writeFileSync(path.join(dir, 'caveman.mdc'), '# original\n');
-  execFileSync(process.execPath, [INIT, tmp, '--force'], { encoding: 'utf8' });
+  runInit(tmp, '--force');
   const after = fs.readFileSync(path.join(dir, 'caveman.mdc'), 'utf8');
   assert.match(after, /alwaysApply: true/);
   assert.match(after, /Respond terse/);
 });
 
 test('--dry-run: announces but writes nothing', (tmp) => {
-  const out = execFileSync(process.execPath, [INIT, tmp, '--dry-run'], { encoding: 'utf8' });
+  const out = runInit(tmp, '--dry-run');
   assert.match(out, /\(dry run\)/);
-  assert.match(out, /5 added/);
+  assert.match(out, /6 added/);
   assert.ok(!fs.existsSync(path.join(tmp, '.cursor')));
   assert.ok(!fs.existsSync(path.join(tmp, '.windsurf')));
   assert.ok(!fs.existsSync(path.join(tmp, '.clinerules')));
   assert.ok(!fs.existsSync(path.join(tmp, '.github/copilot-instructions.md')));
+  assert.ok(!fs.existsSync(path.join(tmp, '.opencode')));
   assert.ok(!fs.existsSync(path.join(tmp, 'AGENTS.md')));
 });
 
 test('--only filters to one target', (tmp) => {
-  const out = execFileSync(process.execPath, [INIT, tmp, '--only', 'cline'], { encoding: 'utf8' });
+  const out = runInit(tmp, '--only', 'cline');
   assert.match(out, /1 added/);
   assert.ok(fs.existsSync(path.join(tmp, '.clinerules/caveman.md')));
   assert.ok(!fs.existsSync(path.join(tmp, '.cursor')));
@@ -104,7 +118,7 @@ test('detects sentinel and skips files that already have caveman content', (tmp)
   fs.mkdirSync(dir, { recursive: true });
   fs.writeFileSync(path.join(dir, 'caveman.md'),
     '# Existing\n\nRespond terse like smart caveman. Hello.\n');
-  const out = execFileSync(process.execPath, [INIT, tmp, '--only', 'cline'], { encoding: 'utf8' });
+  const out = runInit(tmp, '--only', 'cline');
   assert.match(out, /skipped-already-installed/);
 });
 

tests/verify_repo.py

@@ -158,7 +158,6 @@ def verify_manifests_and_syntax() -> None:
     section("Manifests And Syntax")
 
     manifest_paths = [
-        ROOT / ".agents/plugins/marketplace.json",
         ROOT / ".claude-plugin/plugin.json",
         ROOT / ".claude-plugin/marketplace.json",
         ROOT / ".codex/hooks.json",