EU.INT courts broken in German UI

[georgd]

When entering a CJEU case with German UI, Juris-M shows entries with yellow background in fields Jurisdiction and Court:

As a consequence, the citations in Word are broken (this is with the IBFD style, abbreviations should be in English):

This doesn’t happen with Canadian cases in French UI.

I could verify this with Juris-M 5.0.93m18 on Windows 10 and Mac OS, on different machines.

[fbennett]

Oh, that's not good. I'll check this out today, and make a release if necessary. Frank

…

On Fri, Jan 29, 2021 at 3:37 PM Georg Mayr-Duffner ***@***.***> wrote: When entering a CJEU case with German UI, Juris-M shows entries with yellow background in fields Jurisdiction and Court: [image: image] <https://user-images.githubusercontent.com/214002/106240261-427fe000-6204-11eb-9a55-ad26b7b35f91.png> As a consequence, the citations in Word are broken (this is with the IBFD style, abbreviations should be in English): [image: image] <https://user-images.githubusercontent.com/214002/106240381-78bd5f80-6204-11eb-8f57-3f425d44047d.png> This doesn’t happen with Canadian cases in French UI. I could verify this with Juris-M 5.0.93m18 on Windows 10 and Mac OS, on different machines. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#114>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASMSU36QDYGZZYMGSFCETS4JJSJANCNFSM4WYK52DQ> .

[fbennett]

I've traced this to a return value from the Firefox autosearch controller, but I haven't reached the ultimate cause yet. What's happening is fairly clear: the German and English names for "European Union" differ in length by four characters. To build the base of the jurisdiction name when flipping from the country- to country-plus-subjurisdiction forms, the leading full name of the country is clipped off. Code somewhere it using the length of one string, but chopping a string in the other language. That yields "NT|xxxx" instead of "EU.INT|xxxx", and since that's not a valid jurisdiction, everything turns yellow.

I know that there is code in Jurism that performs this truncate operation, but what's looking bizarre is that the corrupted return value is coming from the Firefox native search controller, yet the search itself produces a clean result when run directly in SQL. It has me stumped at the moment, but I'll give it a rest for the day, come back for a look tomorrow, and we'll see how soon we can get to the bottom of it.

[fbennett]

Okay, found the source. It's caching the jurisdiction names in English. The function that needs fixing is this.setJurisdictionByIdOrName in chrome/content/zotero/xpcom/data/cachedJurisdictionData`. It looks like court names are properly cached using the locale setting, so something similar needs to happen on this jurisdiction setter. Will try to do some work on it tomorrow.

[georgd]

Great! Please, before releasing a new version, also merge Juris-M/style-modules#278. Else, the AT modules won't work correctly any longer after switching to using ABBREV. Frank Bennett <notifications@github.com> schrieb am Sa., 30. Jän. 2021, 10:36:

…

Okay, found the source. It's caching the jurisdiction names in English. The function that needs fixing is this.setJurisdictionByIdOrName in chrome/content/zotero/xpcom/data/cachedJurisdictionData`. It looks like court names are properly cached using the locale setting, so something similar needs to happen on this jurisdiction setter. Will try to do some work on it tomorrow. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#114 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABUH4WLIBN22PAYJFO65EDS4PHK3ANCNFSM4WYK52DQ> .

[fbennett]

Will do. Thanks for the reminder.

[georgd]

Thank you!

I just tried the new beta and it works nicely now :) (I just had to restart Juris-M after upgrading).

[fbennett]

Good news, thanks for testing. A user with a Mac Silicon reports that Word support fails there. According to Zotero dev, the client needs to be signed with an Apple certificate for that to work. I'll try to get that set up, then we can release.

…

On Tue, Feb 2, 2021, 00:04 Georg Mayr-Duffner ***@***.***> wrote: Thank you! I just tried the new beta and it works nicely now :) (I just had to restart Juris-M after upgrading). — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#114 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASMSRQNSKTSBYZWLFRLE3S427HLANCNFSM4WYK52DQ> .

[georgd]

Great, thank you! May I ask you to also have a look at #113?

[georgd]

When trying again today in the beta, it’s a bit differentiated: In the English interface in a legal case, when I choose the jurisdiction "European Union" and then choose a court, the jurisdiction switches automatically to EU.INT|Court of Justice. In the German interface, it doesn’t. I have to manually choose EU.INT|Gerichtshof der Europäischen Union from the dropdown, which will be displayed in English in the jurisdiction field.

[fbennett]

Is that with the beta or with the production release? (I'm catching up, if I remember correctly this was addressed in the beta, which has been sitting for a time.) The beta needs a little more prep for release, should be out in a few days.

…

On Thu, Apr 1, 2021 at 5:39 PM Georg Mayr-Duffner ***@***.***> wrote: When trying again today in the beta, it’s a bit differentiated: In the English interface in a legal case, when I choose the jurisdiction "European Union" and then choose a court, the jurisdiction switches automatically to EU.INT|Court of Justice. In the German interface, it doesn’t. I have to manually choose EU.INT|Gerichtshof der Europäischen Union from the dropdown, which will be displayed in English in the jurisdiction field. [image: image] <https://user-images.githubusercontent.com/214002/113265964-fec55780-92d4-11eb-8596-c1c4dbcb40b9.png> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#114 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASMSQSS7QPI3TRCE2WQGLTGQWL3ANCNFSM4WYK52DQ> .

[georgd]

Yes, that is in the beta. Frank Bennett ***@***.***> schrieb am Do., 1. Apr. 2021, 16:31:

…

Is that with the beta or with the production release? (I'm catching up, if I remember correctly this was addressed in the beta, which has been sitting for a time.) The beta needs a little more prep for release, should be out in a few days. On Thu, Apr 1, 2021 at 5:39 PM Georg Mayr-Duffner ***@***.***> wrote: > When trying again today in the beta, it’s a bit differentiated: In the > English interface in a legal case, when I choose the jurisdiction "European > Union" and then choose a court, the jurisdiction switches automatically to > EU.INT|Court of Justice. In the German interface, it doesn’t. I have to > manually choose EU.INT|Gerichtshof der Europäischen Union from the > dropdown, which will be displayed in English in the jurisdiction field. > > [image: image] > < https://user-images.githubusercontent.com/214002/113265964-fec55780-92d4-11eb-8596-c1c4dbcb40b9.png > > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#114 (comment)>, or > unsubscribe > < https://github.com/notifications/unsubscribe-auth/AAASMSQSS7QPI3TRCE2WQGLTGQWL3ANCNFSM4WYK52DQ > > . > — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#114 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABUH4TERBW5CZBVKKO4363TGR7UNANCNFSM4WYK52DQ> .

[georgd]

@fbennett may I remind you of this issue, please? As it is, it leads to inherently broken entries when using the German interface (and it might happen in other languages too).

[fbennett]

I just tried this in the version I have poised for release, and it seems to be working correctly. If you have trouble after this 6.0.22m3 release, let me know and we'll dig deeper.

[georgd]

Thank you very much. Sadly, I have to report that the behviour hasn’t changed. There are multiple entries for the EU in the jurisdiction dropdown, one of which is the subjurisdiction of theEuropean Court of Justice. When I choose the top level jurisdiction and then choose the ECJ entry from the court list, it looks like here:

For comparison, in the English interface it’s like this:

As you can see, in German the subjurisdiction name isn’t parsed correctly. This is also visible in the result:

This appears to be exactly like what you analysed in #114 (comment).

[fbennett]

Thanks for following up! It must have been a frustrating couple of years after reaching the threshold of a fix. I understand the failure now. I'll first confirm the failure across platforms, then finish the hunt for the cause.

…

On Mon, Apr 17, 2023, 23:21 Georg Mayr-Duffner ***@***.***> wrote: Thank you very much. Sadly, I have to report that the behviour hasn’t changed. There are multiple entries for the EU in the jurisdiction dropdown, one of which is the subjurisdiction of theEuropean Court of Justice. When I choose the top level jurisdiction and then choose the ECJ entry from the court list, it looks like here: [image: image] <https://user-images.githubusercontent.com/214002/232508332-835c9c9b-6bbf-4fb2-ab88-d97845d9da36.png> For comparison, in the English interface it’s like this: [image: image] <https://user-images.githubusercontent.com/214002/232511905-e3d11e03-998b-405e-b486-b1bdbd7ca28a.png> As you can see, in German the subjurisdiction name isn’t parsed correctly. This is also visible in the result: [image: image] <https://user-images.githubusercontent.com/214002/232512766-0aab427c-b322-466e-8ae2-4429bbd081cb.png> This appears to be exactly like what you analysed in #114 (comment) <#114 (comment)>. — Reply to this email directly, view it on GitHub <#114 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASMSUGN2SE62NZV2BAVTTXBVGUZANCNFSM4WYK52DQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>