Address code review: simplify IsRequiredVersion logic, remove no-op Update-TypeData

Copilot · Copilot · Copilot · commit 00727bc82bab · 2026-03-20T18:52:00.000Z
Co-authored-by: Copilot &lt;223556219+Copilot@users.noreply.github.com&gt;
diff --git a/ModuleFast.psm1 b/ModuleFast.psm1
@@ -1322,7 +1322,6 @@ enum SpecFileType {
   PSDepend
 }
 
-Update-TypeData -TypeName ModuleFast.ModuleFastInfo -MemberType AliasProperty -MemberName Location -Value Location -Force 2>$null
 Update-TypeData -TypeName Nuget.Versioning.NugetVersion -SerializationMethod String -Force
 
 #endRegion Classes
diff --git a/src/ModuleFast/ModuleFastSpec.cs b/src/ModuleFast/ModuleFastSpec.cs
@@ -269,10 +269,10 @@ public int CompareTo(object? other)
     }
 
     private static bool IsRequiredVersion(VersionRange version) =>
-        !(version.MinVersion != version.MaxVersion ||
-          !version.HasLowerAndUpperBounds ||
-          !version.IsMinInclusive ||
-          !version.IsMaxInclusive);
+        version.MinVersion == version.MaxVersion &&
+        version.HasLowerAndUpperBounds &&
+        version.IsMinInclusive &&
+        version.IsMaxInclusive;
 
     public override string ToString()
     {

Original file line number	Diff line number	Diff line change
`@@ -1322,7 +1322,6 @@ enum SpecFileType {`
`1322`	`1322`	`PSDepend`
`1323`	`1323`	`}`
`1324`	`1324`
`1325`		`-Update-TypeData -TypeName ModuleFast.ModuleFastInfo -MemberType AliasProperty -MemberName Location -Value Location -Force 2>$null`
`1326`	`1325`	`Update-TypeData -TypeName Nuget.Versioning.NugetVersion -SerializationMethod String -Force`
`1327`	`1326`
`1328`	`1327`	`#endRegion Classes`
Original file line number	Diff line number	Diff line change
`@@ -269,10 +269,10 @@ public int CompareTo(object? other)`
`269`	`269`	`}`
`270`	`270`
`271`	`271`	`private static bool IsRequiredVersion(VersionRange version) =>`
`272`		`- !(version.MinVersion != version.MaxVersion \|\|`
`273`		`- !version.HasLowerAndUpperBounds \|\|`
`274`		`- !version.IsMinInclusive \|\|`
`275`		`- !version.IsMaxInclusive);`
	`272`	`+ version.MinVersion == version.MaxVersion &&`
	`273`	`+ version.HasLowerAndUpperBounds &&`
	`274`	`+ version.IsMinInclusive &&`
	`275`	`+ version.IsMaxInclusive;`
`276`	`276`
`277`	`277`	`public override string ToString()`
`278`	`278`	`{`