fix: quote normalization via black

Author: Justintime50

CHANGELOG.md

@@ -1,10 +1,11 @@
 # CHANGELOG
 
-## Next Release
+## v2.2.0 (2025-10-17)
 
 - Corrects broken brew path to Python (closes #64)
 - Properly creates a local tap to link local changes to appease `brew update-python-resources`
 - Disables brew updates, analytics, install cleanup, and hints for less noisy and faster builds
+- De-classes the entire app leaning into functional programming (since all methods were static anyway)
 
 ## v2.1.3 (2025-07-23)
 

homebrew_releaser/_version.py

@@ -1 +1 @@
-__version__ = '2.1.3'
+__version__ = "2.2.0"

homebrew_releaser/app.py

@@ -47,22 +47,22 @@
 )
 
 
-GITHUB_BASE_URL = 'https://api.github.com'
+GITHUB_BASE_URL = "https://api.github.com"
 
 # Required GitHub Action env variables from user
-INSTALL = os.getenv('INPUT_INSTALL')
-HOMEBREW_OWNER = os.getenv('INPUT_HOMEBREW_OWNER')
+INSTALL = os.getenv("INPUT_INSTALL")
+HOMEBREW_OWNER = os.getenv("INPUT_HOMEBREW_OWNER")
 
 # Optional GitHub Action env variables from user
-COMMIT_OWNER = os.getenv('INPUT_COMMIT_OWNER', 'homebrew-releaser')
-COMMIT_EMAIL = os.getenv('INPUT_COMMIT_EMAIL', '[email protected]')
-DEPENDS_ON = os.getenv('INPUT_DEPENDS_ON')
-TEST = os.getenv('INPUT_TEST')
+COMMIT_OWNER = os.getenv("INPUT_COMMIT_OWNER", "homebrew-releaser")
+COMMIT_EMAIL = os.getenv("INPUT_COMMIT_EMAIL", "[email protected]")
+DEPENDS_ON = os.getenv("INPUT_DEPENDS_ON")
+TEST = os.getenv("INPUT_TEST")
 UPDATE_README_TABLE = (
-    os.getenv('INPUT_UPDATE_README_TABLE', False) if os.getenv('INPUT_UPDATE_README_TABLE') != 'false' else False
+    os.getenv("INPUT_UPDATE_README_TABLE", False) if os.getenv("INPUT_UPDATE_README_TABLE") != "false" else False
 )  # Must check for string `false` since GitHub Actions passes the bool as a string
 DEBUG = (
-    os.getenv('INPUT_DEBUG', False) if os.getenv('INPUT_DEBUG') != 'false' else False
+    os.getenv("INPUT_DEBUG", False) if os.getenv("INPUT_DEBUG") != "false" else False
 )  # Must check for string `false` since GitHub Actions passes the bool as a string
 
 
@@ -80,52 +80,52 @@ def run_github_action():
     _setup_logger()
     logger = woodchips.get(LOGGER_NAME)
 
-    logger.info(f'Starting Homebrew Releaser v{__version__}...')
+    logger.info(f"Starting Homebrew Releaser v{__version__}...")
     _check_required_env_variables()
 
-    logger.info('Setting up git environment...')
+    logger.info("Setting up git environment...")
     setup_git(COMMIT_OWNER, COMMIT_EMAIL, HOMEBREW_OWNER, HOMEBREW_TAP)
 
-    logger.info(f'Collecting data about {GITHUB_REPO}...')
-    repository = make_github_get_request(url=f'{GITHUB_BASE_URL}/repos/{GITHUB_OWNER}/{GITHUB_REPO}').json()
+    logger.info(f"Collecting data about {GITHUB_REPO}...")
+    repository = make_github_get_request(url=f"{GITHUB_BASE_URL}/repos/{GITHUB_OWNER}/{GITHUB_REPO}").json()
     latest_release = make_github_get_request(
-        url=f'https://api.github.com/repos/{GITHUB_OWNER}/{GITHUB_REPO}/releases/latest'
+        url=f"https://api.github.com/repos/{GITHUB_OWNER}/{GITHUB_REPO}/releases/latest"
     ).json()
-    assets = latest_release['assets']
-    version = VERSION or latest_release['tag_name']
-    version_no_v = version.lstrip('v')
-    logger.info(f'Latest release ({version}) successfully identified!')
+    assets = latest_release["assets"]
+    version = VERSION or latest_release["tag_name"]
+    version_no_v = version.lstrip("v")
+    logger.info(f"Latest release ({version}) successfully identified!")
 
-    logger.info('Generating tar archive checksum(s)...')
+    logger.info("Generating tar archive checksum(s)...")
     archive_urls = []
-    archive_checksum_entries = ''
+    archive_checksum_entries = ""
 
     # Auto-generated tar URL must come first for later use (order is important)
     if repository["private"]:
-        logger.debug('Repository is private. Using auto-generated release tarball and zipball REST API endpoints.')
-        archive_base_url = f'{GITHUB_BASE_URL}/repos/{GITHUB_OWNER}/{GITHUB_REPO}'
-        auto_generated_release_tar = f'{archive_base_url}/tarball/{version}'
-        auto_generated_release_zip = f'{archive_base_url}/zipball/{version}'
+        logger.debug("Repository is private. Using auto-generated release tarball and zipball REST API endpoints.")
+        archive_base_url = f"{GITHUB_BASE_URL}/repos/{GITHUB_OWNER}/{GITHUB_REPO}"
+        auto_generated_release_tar = f"{archive_base_url}/tarball/{version}"
+        auto_generated_release_zip = f"{archive_base_url}/zipball/{version}"
     else:
-        logger.debug('Repository is public. Using auto-generated release tarball and zipball public URLs.')
-        archive_base_url = f'https://github.com/{GITHUB_OWNER}/{GITHUB_REPO}/archive/refs/tags/{version}'
-        auto_generated_release_tar = f'{archive_base_url}.tar.gz'
-        auto_generated_release_zip = f'{archive_base_url}.zip'
+        logger.debug("Repository is public. Using auto-generated release tarball and zipball public URLs.")
+        archive_base_url = f"https://github.com/{GITHUB_OWNER}/{GITHUB_REPO}/archive/refs/tags/{version}"
+        auto_generated_release_tar = f"{archive_base_url}.tar.gz"
+        auto_generated_release_zip = f"{archive_base_url}.zip"
 
     archive_urls.append(auto_generated_release_tar)
     archive_urls.append(auto_generated_release_zip)
 
     target_browser_download_base_url = (
-        f'https://github.com/{GITHUB_OWNER}/{GITHUB_REPO}/releases/download/{version}/{GITHUB_REPO}-{version_no_v}'
+        f"https://github.com/{GITHUB_OWNER}/{GITHUB_REPO}/releases/download/{version}/{GITHUB_REPO}-{version_no_v}"
     )
     if TARGET_DARWIN_AMD64:
-        archive_urls.append(f'{target_browser_download_base_url}-darwin-amd64.tar.gz')
+        archive_urls.append(f"{target_browser_download_base_url}-darwin-amd64.tar.gz")
     if TARGET_DARWIN_ARM64:
-        archive_urls.append(f'{target_browser_download_base_url}-darwin-arm64.tar.gz')
+        archive_urls.append(f"{target_browser_download_base_url}-darwin-arm64.tar.gz")
     if TARGET_LINUX_AMD64:
-        archive_urls.append(f'{target_browser_download_base_url}-linux-amd64.tar.gz')
+        archive_urls.append(f"{target_browser_download_base_url}-linux-amd64.tar.gz")
     if TARGET_LINUX_ARM64:
-        archive_urls.append(f'{target_browser_download_base_url}-linux-arm64.tar.gz')
+        archive_urls.append(f"{target_browser_download_base_url}-linux-arm64.tar.gz")
 
     checksums = []
     for archive_url in archive_urls:
@@ -136,24 +136,24 @@ def run_github_action():
             if archive_url == auto_generated_release_tar or archive_url == auto_generated_release_zip:
                 download_url = archive_url
             else:
-                download_url = asset['url']
+                download_url = asset["url"]
 
             if (
                 archive_url == auto_generated_release_tar
                 or archive_url == auto_generated_release_zip
-                or archive_url == asset['browser_download_url']
+                or archive_url == asset["browser_download_url"]
             ):
                 # For REST API requests, we should not stream archive file, but it is fine for browser URLs
                 stream = False if archive_url.find("api.github.com") != -1 else True
                 downloaded_filename = _download_archive(download_url, stream)
                 checksum = calculate_checksum(downloaded_filename)
                 archive_filename = get_filename_from_path(archive_url)
-                archive_checksum_entries += f'{checksum} {archive_filename}\n'
+                archive_checksum_entries += f"{checksum} {archive_filename}\n"
                 checksums.append(
                     {
                         archive_filename: {
-                            'checksum': checksum,
-                            'url': archive_url,
+                            "checksum": checksum,
+                            "url": archive_url,
                         }
                     },
                 )
@@ -162,7 +162,7 @@ def run_github_action():
 
     write_file(CHECKSUM_FILE, archive_checksum_entries)
 
-    logger.info(f'Generating Homebrew formula for {GITHUB_REPO}...')
+    logger.info(f"Generating Homebrew formula for {GITHUB_REPO}...")
     template = generate_formula_data(
         GITHUB_OWNER,
         GITHUB_REPO,
@@ -182,49 +182,49 @@ def run_github_action():
     formula_filename = f'{repository["name"]}.rb'
     formula_dir = get_working_dir(os.path.join(HOMEBREW_TAP, FORMULA_FOLDER))
     formula_filepath = os.path.join(formula_dir, formula_filename)
-    write_file(formula_filepath, template, 'w')
+    write_file(formula_filepath, template, "w")
 
     if UPDATE_PYTHON_RESOURCES:
-        logger.info('Attempting to update Python resources in the formula...')
+        logger.info("Attempting to update Python resources in the formula...")
         setup_homebrew_tap(HOMEBREW_OWNER, HOMEBREW_TAP, formula_dir)
         update_python_resources(formula_dir, formula_filename)
         if DEBUG:
-            with open(formula_filepath, 'r') as formula_file:
+            with open(formula_filepath, "r") as formula_file:
                 formula_content = formula_file.read()
                 logger.debug(formula_content)
     else:
-        logger.debug('Skipping update to Python resources.')
+        logger.debug("Skipping update to Python resources.")
 
     if UPDATE_README_TABLE:
-        logger.info('Attempting to update the README\'s project table...')
+        logger.info("Attempting to update the README's project table...")
         update_readme(HOMEBREW_TAP)
     else:
-        logger.debug('Skipping update to project README.')
+        logger.debug("Skipping update to project README.")
 
     # Although users can skip a commit, still commit (but don't push) to dry-run the commit for debugging purposes
     add_git(HOMEBREW_TAP)
     commit_git(HOMEBREW_TAP, GITHUB_REPO, version)
 
     if SKIP_COMMIT:
-        logger.info(f'Skipping upload of checksum.txt to {HOMEBREW_TAP}.')
-        logger.info(f'Skipping push to {HOMEBREW_TAP}.')
+        logger.info(f"Skipping upload of checksum.txt to {HOMEBREW_TAP}.")
+        logger.info(f"Skipping push to {HOMEBREW_TAP}.")
     else:
-        logger.info(f'Attempting to upload checksum.txt to the latest release of {GITHUB_REPO}...')
+        logger.info(f"Attempting to upload checksum.txt to the latest release of {GITHUB_REPO}...")
         upload_checksum_file(latest_release)
-        logger.info(f'Attempting to release {version} of {GITHUB_REPO} to {HOMEBREW_TAP}...')
+        logger.info(f"Attempting to release {version} of {GITHUB_REPO} to {HOMEBREW_TAP}...")
         push_git(HOMEBREW_TAP, HOMEBREW_OWNER)
-        logger.info(f'Successfully released {version} of {GITHUB_REPO} to {HOMEBREW_TAP}!')
+        logger.info(f"Successfully released {version} of {GITHUB_REPO} to {HOMEBREW_TAP}!")
 
 
 def _setup_logger():
     """Setup a `woodchips` logger instance."""
-    logging_level = 'DEBUG' if DEBUG else 'INFO'
+    logging_level = "DEBUG" if DEBUG else "INFO"
 
     logger = woodchips.Logger(
         name=LOGGER_NAME,
         level=logging_level,
     )
-    logger.log_to_console(formatter='%(asctime)s - %(levelname)s - %(message)s')
+    logger.log_to_console(formatter="%(asctime)s - %(levelname)s - %(message)s")
 
 
 def _check_required_env_variables():
@@ -241,9 +241,9 @@ def _check_required_env_variables():
     for env_variable in required_env_variables:
         if not env_variable:
             raise SystemExit(
-                'You must provide all necessary environment variables. Please reference the Homebrew Releaser documentation.'  # noqa
+                "You must provide all necessary environment variables. Please reference the Homebrew Releaser documentation."  # noqa
             )
-    logger.debug('All required environment variables are present.')
+    logger.debug("All required environment variables are present.")
 
 
 def _download_archive(url: str, stream: Optional[bool] = False) -> str:
@@ -253,7 +253,7 @@ def _download_archive(url: str, stream: Optional[bool] = False) -> str:
         stream=stream,
     )
     filename = get_filename_from_path(url)
-    write_file(filename, response.content, 'wb')
+    write_file(filename, response.content, "wb")
 
     return filename
 
@@ -262,5 +262,5 @@ def main():
     run_github_action()
 
 
-if __name__ == '__main__':
+if __name__ == "__main__":
     main()

homebrew_releaser/checksum.py

@@ -22,7 +22,7 @@ def calculate_checksum(tar_filepath: str) -> str:
     try:
         with open(get_working_dir(tar_filepath), "rb") as content:
             checksum = hashlib.sha256(content.read()).hexdigest()
-        logger.debug(f'Checksum for {tar_filepath} generated successfully: {checksum}')
+        logger.debug(f"Checksum for {tar_filepath} generated successfully: {checksum}")
     except Exception as error:
         raise SystemExit(error)
 
@@ -33,14 +33,14 @@ def upload_checksum_file(latest_release: dict[str, Any]):
     """Uploads a `checksum.txt` file to the latest release of the repo."""
     logger = woodchips.get(LOGGER_NAME)
 
-    latest_release_id = latest_release['id']
+    latest_release_id = latest_release["id"]
 
-    with open(get_working_dir(CHECKSUM_FILE), 'rb') as filename:
+    with open(get_working_dir(CHECKSUM_FILE), "rb") as filename:
         checksum_file_content = filename.read()
 
-    upload_url = f'https://uploads.github.com/repos/{GITHUB_OWNER}/{GITHUB_REPO}/releases/{latest_release_id}/assets?name={CHECKSUM_FILE}'  # noqa
+    upload_url = f"https://uploads.github.com/repos/{GITHUB_OWNER}/{GITHUB_REPO}/releases/{latest_release_id}/assets?name={CHECKSUM_FILE}"  # noqa
     headers = GITHUB_HEADERS.copy()
-    headers['Content-Type'] = 'text/plain'
+    headers["Content-Type"] = "text/plain"
 
     try:
         response = requests.post(
@@ -50,6 +50,6 @@ def upload_checksum_file(latest_release: dict[str, Any]):
             timeout=TIMEOUT,
         )
         response.raise_for_status()
-        logger.info(f'checksum.txt uploaded successfully to {GITHUB_REPO}.')
+        logger.info(f"checksum.txt uploaded successfully to {GITHUB_REPO}.")
     except requests.exceptions.RequestException as error:
         raise SystemExit(error)

homebrew_releaser/constants.py

@@ -2,56 +2,56 @@
 
 
 # User Input
-FORMULA_FOLDER = os.getenv('INPUT_FORMULA_FOLDER', 'Formula')
-GITHUB_TOKEN = os.getenv('INPUT_GITHUB_TOKEN')
-HOMEBREW_TAP = os.getenv('INPUT_HOMEBREW_TAP')
+FORMULA_FOLDER = os.getenv("INPUT_FORMULA_FOLDER", "Formula")
+GITHUB_TOKEN = os.getenv("INPUT_GITHUB_TOKEN")
+HOMEBREW_TAP = os.getenv("INPUT_HOMEBREW_TAP")
 SKIP_COMMIT = (
-    os.getenv('INPUT_SKIP_COMMIT', False) if os.getenv('INPUT_SKIP_COMMIT') != 'false' else False
+    os.getenv("INPUT_SKIP_COMMIT", False) if os.getenv("INPUT_SKIP_COMMIT") != "false" else False
 )  # Must check for string `false` since GitHub Actions passes the bool as a string
-DOWNLOAD_STRATEGY = os.getenv('INPUT_DOWNLOAD_STRATEGY')
-CUSTOM_REQUIRE = os.getenv('INPUT_CUSTOM_REQUIRE')
-FORMULA_INCLUDES = os.getenv('INPUT_FORMULA_INCLUDES')
+DOWNLOAD_STRATEGY = os.getenv("INPUT_DOWNLOAD_STRATEGY")
+CUSTOM_REQUIRE = os.getenv("INPUT_CUSTOM_REQUIRE")
+FORMULA_INCLUDES = os.getenv("INPUT_FORMULA_INCLUDES")
 UPDATE_PYTHON_RESOURCES = (
     os.getenv("INPUT_UPDATE_PYTHON_RESOURCES", False)
     if os.getenv("INPUT_UPDATE_PYTHON_RESOURCES") != "false"
     else False
 )
-VERSION = os.getenv('INPUT_VERSION')
+VERSION = os.getenv("INPUT_VERSION")
 
 # App Constants
-LOGGER_NAME = 'homebrew-releaser'
+LOGGER_NAME = "homebrew-releaser"
 TIMEOUT = 300
 GITHUB_HEADERS = {
-    'Accept': 'application/vnd.github.v3+json',
-    'Agent': 'Homebrew Releaser',
-    'Authorization': f'Bearer {GITHUB_TOKEN}',
+    "Accept": "application/vnd.github.v3+json",
+    "Agent": "Homebrew Releaser",
+    "Authorization": f"Bearer {GITHUB_TOKEN}",
 }
-CHECKSUM_FILE = 'checksum.txt'
-WORKING_DIR = '/tmp/homebrew-releaser'  # nosec
+CHECKSUM_FILE = "checksum.txt"
+WORKING_DIR = "/tmp/homebrew-releaser"  # nosec
 
 # Formula Constants
 ARTICLES = {
-    'a',
-    'an',
-    'the',
+    "a",
+    "an",
+    "the",
 }
 MAX_DESC_FIELD_LENGTH = 80  # `brew audit` wants no more than 80 characters in the desc field
 
 # GitHub Action env variables set by GitHub
-GITHUB_REPOSITORY = os.getenv('GITHUB_REPOSITORY', 'user/repo').split('/')
+GITHUB_REPOSITORY = os.getenv("GITHUB_REPOSITORY", "user/repo").split("/")
 GITHUB_OWNER = GITHUB_REPOSITORY[0]
 GITHUB_REPO = GITHUB_REPOSITORY[1]
 
 # Matrix targets to add URL/checksum targets for
 TARGET_DARWIN_AMD64 = (
-    os.getenv('INPUT_TARGET_DARWIN_AMD64', False) if os.getenv('INPUT_TARGET_DARWIN_AMD64') != 'false' else False
+    os.getenv("INPUT_TARGET_DARWIN_AMD64", False) if os.getenv("INPUT_TARGET_DARWIN_AMD64") != "false" else False
 )  # Must check for string `false` since GitHub Actions passes the bool as a string
 TARGET_DARWIN_ARM64 = (
-    os.getenv('INPUT_TARGET_DARWIN_ARM64', False) if os.getenv('INPUT_TARGET_DARWIN_ARM64') != 'false' else False
+    os.getenv("INPUT_TARGET_DARWIN_ARM64", False) if os.getenv("INPUT_TARGET_DARWIN_ARM64") != "false" else False
 )  # Must check for string `false` since GitHub Actions passes the bool as a string
 TARGET_LINUX_AMD64 = (
-    os.getenv('INPUT_TARGET_LINUX_AMD64', False) if os.getenv('INPUT_TARGET_LINUX_AMD64') != 'false' else False
+    os.getenv("INPUT_TARGET_LINUX_AMD64", False) if os.getenv("INPUT_TARGET_LINUX_AMD64") != "false" else False
 )  # Must check for string `false` since GitHub Actions passes the bool as a string
 TARGET_LINUX_ARM64 = (
-    os.getenv('INPUT_TARGET_LINUX_ARM64', False) if os.getenv('INPUT_TARGET_LINUX_ARM64') != 'false' else False
+    os.getenv("INPUT_TARGET_LINUX_ARM64", False) if os.getenv("INPUT_TARGET_LINUX_ARM64") != "false" else False
 )  # Must check for string `false` since GitHub Actions passes the bool as a string