Skip to content

Commit 4962361

Browse files
committed
fix(server): run-scope notebook harvest dedup key; drop dead imports
1 parent 320ecf1 commit 4962361

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

server/src/agent/notebook-bridge.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import fs from "node:fs";
1515
import path from "node:path";
1616
import type { ExtensionFactory } from "@earendil-works/pi-coding-agent";
1717
import type { ProjectPaths } from "../projects.ts";
18-
import { appendNotebookEntry, type NotebookEntry } from "./notebook-store.ts";
18+
import { appendNotebookEntry } from "./notebook-store.ts";
1919
import { notebookEntriesFromSessionFile } from "./notebook-harvest.ts";
2020

2121
/** Absolute dir of the vendored kady-notebook package. */
@@ -78,8 +78,9 @@ export function makeSubagentNotebookExtension(
7878
if (!r.agent || !r.sessionFile) continue;
7979
const entries = notebookEntriesFromSessionFile(r.sessionFile, r.agent);
8080
for (const entry of entries) {
81-
if (harvestedIds.has(entry.id)) continue;
82-
harvestedIds.add(entry.id);
81+
const dedupKey = `${r.sessionFile}:${entry.id}`;
82+
if (harvestedIds.has(dedupKey)) continue;
83+
harvestedIds.add(dedupKey);
8384
if (harvestedIds.size > 5000) harvestedIds.clear();
8485
appendNotebookEntry(parentSession, entry, projectId);
8586
}

server/test/notebook-subagent-bridge.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { describe, it, expect, beforeEach } from "vitest";
22
import fs from "node:fs";
33
import path from "node:path";
44
import { makeSubagentNotebookExtension } from "../src/agent/notebook-bridge.ts";
5-
import { readNotebookEntries, appendNotebookEntry } from "../src/agent/notebook-store.ts";
5+
import { readNotebookEntries } from "../src/agent/notebook-store.ts";
66
import { resolvePaths } from "../src/projects.ts";
77
import { PROJECTS_ROOT } from "../src/config.ts";
88

0 commit comments

Comments
 (0)