feat(web): add localStorage shim for Node environments and enhance AssistantMessageBody to handle silent turn endings

Author: TKassis

web/src/components/chat-tab.tsx

@@ -898,18 +898,25 @@ function ChatInput({
 function AssistantMessageBody({
   message,
   isStreaming,
+  isLast,
   sessionId,
   onViewInNotebook,
 }: {
   message: ChatMessage;
   isStreaming: boolean;
+  isLast: boolean;
   sessionId: string | null;
   onViewInNotebook?: (entryId: string) => void;
 }) {
   const activities = message.activities ?? [];
   const hasReasoning = Boolean(message.reasoning?.trim());
   const hasAnything =
     Boolean(message.content) || activities.length > 0 || hasReasoning;
+  // Some models occasionally end a turn right after a tool call with no
+  // closing text, which used to leave the chat silently "done". Surface that
+  // explicitly on the final bubble so the user knows the run ended.
+  const endedWithoutReply =
+    !isStreaming && isLast && !message.content && (activities.length > 0 || hasReasoning);
 
   // Interview tool calls render as interactive forms, and notebook calls as
   // compact pointer chips, in stream order between the surrounding tool cards
@@ -948,6 +955,11 @@ function AssistantMessageBody({
         <Shimmer className="text-sm" duration={1.5}>
           Thinking...
         </Shimmer>
+      ) : endedWithoutReply ? (
+        <p className="text-xs italic text-muted-foreground">
+          The model finished this turn without a closing message. The tool
+          results above are the outcome; ask a follow-up if you want a summary.
+        </p>
       ) : null}
       {message.citations && (
         <div className="flex flex-wrap items-center gap-2">
@@ -1358,13 +1370,14 @@ export const ChatTab = forwardRef<ChatTabHandle, ChatTabProps>(function ChatTab(
               description="I can research topics, write code, and analyze data."
             />
           ) : (
-            messages.map((message) => (
+            messages.map((message, i) => (
               <Message from={message.role} key={message.id}>
                 <MessageContent>
                   {message.role === "assistant" ? (
                     <AssistantMessageBody
                       message={message}
                       isStreaming={isStreaming}
+                      isLast={i === messages.length - 1}
                       sessionId={sessionId}
                       onViewInNotebook={onViewInNotebook}
                     />

web/src/lib/use-notebook-annotations.ts

@@ -46,7 +46,20 @@ export function useNotebookAnnotations(sessionId: string | null, enabled: boolea
         if (!res.ok) return; // absent sidecar → keep empty envelope
         const data = normalizeDoc(await res.json());
         if (!cancelled && sessionId === currentSessionRef.current) {
-          setDoc(data);
+          // Merge rather than replace: an optimistic mutation made while this
+          // GET was in flight (e.g. a note added right after opening the
+          // notebook) must not be clobbered by the server's older copy.
+          setDoc((cur) => {
+            if (cur.annotations.length === 0) return data;
+            const serverIds = new Set(data.annotations.map((a) => a.id));
+            return {
+              version: 1,
+              annotations: [
+                ...data.annotations,
+                ...cur.annotations.filter((a) => !serverIds.has(a.id)),
+              ],
+            };
+          });
           lastModifiedRef.current = res.headers.get("Last-Modified");
         }
       } catch {

web/vitest.setup.ts

@@ -25,6 +25,31 @@ if (typeof Element !== "undefined" && typeof Element.prototype.scrollIntoView ==
   Element.prototype.scrollIntoView = () => {};
 }
 
+// On Node >= 22 with experimental WebStorage, Node's own `localStorage`
+// global shadows jsdom's implementation; without --localstorage-file it is
+// undefined, breaking every test that touches window.localStorage.
+if (typeof window !== "undefined" && !window.localStorage) {
+  const store = new Map<string, string>();
+  const localStorageShim: Storage = {
+    get length() {
+      return store.size;
+    },
+    clear: () => store.clear(),
+    getItem: (key: string) => (store.has(key) ? store.get(key)! : null),
+    key: (index: number) => [...store.keys()][index] ?? null,
+    removeItem: (key: string) => {
+      store.delete(key);
+    },
+    setItem: (key: string, value: string) => {
+      store.set(key, String(value));
+    },
+  };
+  Object.defineProperty(window, "localStorage", {
+    configurable: true,
+    value: localStorageShim,
+  });
+}
+
 if (typeof window !== "undefined" && typeof window.matchMedia === "undefined") {
   Object.defineProperty(window, "matchMedia", {
     writable: true,