fix(server): notebook export uses project name; persist sandbox-relative artifacts; test isolation

Author: TKassis

server/src/agent/notebook.ts

@@ -13,8 +13,20 @@
  */
 import { Type, type Static } from "typebox";
 import type { ToolDefinition } from "@earendil-works/pi-coding-agent";
+import { resolvePaths } from "../projects.ts";
 import { appendNotebookEntry, type NotebookEntry } from "./notebook-store.ts";
 
+/** Strip an absolute sandbox-root prefix off a single artifact path so stored
+ *  entries match the sandbox-relative form the live SSE frame already shows
+ *  (see relativizeSandboxPaths in ./events.ts). Non-sandbox/relative paths
+ *  pass through unchanged. */
+function relativizeArtifact(value: string, sandboxRoot: string): string {
+  if (!sandboxRoot) return value;
+  if (value === sandboxRoot) return ".";
+  if (value.startsWith(sandboxRoot + "/")) return value.slice(sandboxRoot.length + 1);
+  return value;
+}
+
 const CodeSchema = Type.Object({
   source: Type.String({ description: "The code/snippet text" }),
   lang: Type.Optional(Type.String({ description: "Language for highlighting" })),
@@ -78,9 +90,13 @@ export function makeNotebookTool(
       const title = (params.title ?? "").trim();
       if (!title) throw new Error("notebook entry needs a non-empty title");
 
+      const sandboxRoot = resolvePaths(projectId).sandbox;
+      const artifacts = params.artifacts?.map((a) => relativizeArtifact(a, sandboxRoot));
+
       const entry: NotebookEntry = {
         ...params,
         title,
+        ...(artifacts !== undefined ? { artifacts } : {}),
         id: toolCallId,
         timestamp: Date.now(),
         role: "agent",

server/src/api/sessions.ts

@@ -7,7 +7,7 @@
  * frame sourced from Pi's per-session usage accounting.
  */
 import type { FastifyInstance } from "fastify";
-import { activePaths } from "../projects.ts";
+import { activePaths, getProject } from "../projects.ts";
 import { corsResponseHeaders } from "../cors.ts";
 import { currentProjectId } from "../scope.ts";
 import { toClientFrame, type ClientFrame } from "../agent/events.ts";
@@ -137,7 +137,8 @@ export async function registerSessionRoutes(app: FastifyInstance): Promise<void>
       try {
         const projectId = currentProjectId();
         const entries = readNotebookEntries(req.params.id, projectId);
-        const md = notebookToMarkdown(entries, { sessionId: req.params.id, projectName: projectId });
+        const projectName = getProject(projectId)?.name ?? projectId;
+        const md = notebookToMarkdown(entries, { sessionId: req.params.id, projectName });
         reply.header("Content-Type", "text/markdown; charset=utf-8");
         reply.header(
           "Content-Disposition",

server/test/notebook-tool.test.ts

@@ -1,10 +1,18 @@
-import { describe, it, expect } from "vitest";
+import fs from "node:fs";
+import { beforeEach, describe, it, expect } from "vitest";
+import { PROJECTS_ROOT } from "../src/config.ts";
+import { resolvePaths } from "../src/projects.ts";
 import { makeNotebookTool } from "../src/agent/notebook.ts";
 import { readNotebookEntries } from "../src/agent/notebook-store.ts";
 
 const run = (tool: ReturnType<typeof makeNotebookTool>, id: string, params: unknown) =>
   tool.execute(id, params as never, undefined as never);
 
+beforeEach(() => {
+  fs.rmSync(PROJECTS_ROOT, { recursive: true, force: true });
+  fs.mkdirSync(PROJECTS_ROOT, { recursive: true });
+});
+
 describe("notebook tool", () => {
   it("persists a stamped entry and returns a non-blocking ack", async () => {
     const s = "sess-tool-a";
@@ -31,6 +39,25 @@ describe("notebook tool", () => {
     expect(typeof entries[0].timestamp).toBe("number");
   });
 
+  it("normalizes an absolute sandbox path in artifacts to sandbox-relative", async () => {
+    const s = "sess-tool-artifacts";
+    const projectId = "default";
+    const tool = makeNotebookTool(projectId, () => s);
+    const sandbox = resolvePaths(projectId).sandbox;
+    await run(tool, "tc_art", {
+      type: "method",
+      title: "Ran PCA",
+      artifacts: [`${sandbox}/figures/fig01.png`, "figures/already-relative.png"],
+    });
+
+    const entries = readNotebookEntries(s, projectId);
+    expect(entries).toHaveLength(1);
+    expect(entries[0].artifacts).toEqual([
+      "figures/fig01.png",
+      "figures/already-relative.png",
+    ]);
+  });
+
   it("rejects an empty title", async () => {
     const tool = makeNotebookTool("default", () => "sess-tool-b");
     await expect(run(tool, "tc_x", { type: "note", title: "  " })).rejects.toThrow(/title/i);