Skip to content

Commit 85445b1

Browse files
Sahil-tarentosreerag-tarentokarthik-tarento
authored
Fix : KB-12962 Event Certificate provider name empty (#33)
Co-authored-by: sreerag <sreerag.sajeesh@tarento.com> Co-authored-by: Karthikeyan Rajendran <70887864+karthik-tarento@users.noreply.github.com>
1 parent 801e6fd commit 85445b1

File tree

2 files changed

+6
-21
lines changed

2 files changed

+6
-21
lines changed

all-actors/src/main/java/org/sunbird/cert/helper/IssueCertificateContentHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ private Map<String, Object> generateCertificateEvent(Map<String, Object> request
349349
eData.put("courseName", courseName);
350350
eData.put("basePath", propertiesCache.getProperty("cert_domain_url") + "/certs");
351351
eData.put("name", certName);
352-
eData.put("providerName", courseInfo.getOrDefault("sourceName", ""));
352+
eData.put("providerName", courseInfo.getOrDefault("providerName", ""));
353353
eData.put("tag", requestMap.get(JsonKeys.BATCH_ID));
354354
eData.put("primaryCategory", courseInfo.getOrDefault("primaryCategory", ""));
355355
eData.put("parentCollections", parentCollections);

all-actors/src/main/java/org/sunbird/cert/helper/IssueCertificateEventHelper.java

Lines changed: 5 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,7 @@ public static Map<String, Object> getCourseInfo(
239239
String courseMetadataString = contentCache.get(courseId, null, 0);
240240
if (StringUtils.isBlank(courseMetadataString)) {
241241
String url = PropertiesCache.getInstance().getProperty("content_basePath") + PropertiesCache.getInstance().getProperty("content_read_api") + "/" + courseId
242-
+ "?fields=name,parentCollections,primaryCategory,posterImage,organisation";
242+
+ "?fields=name,parentCollections,primaryCategory,posterImage,organisation,sourceName";
243243

244244
Map<String, Object> responseObject = getAPICall(url);
245245
Map<String, Object> resultObject = (Map<String,Object>)responseObject.get(JsonKeys.RESULT);
@@ -248,20 +248,15 @@ public static Map<String, Object> getCourseInfo(
248248
String courseName = sanitizeString((String) response.getOrDefault("name", ""));
249249
String primaryCategory = sanitizeString((String) response.getOrDefault("primaryCategory", ""));
250250
String posterImage = sanitizeString((String) response.getOrDefault("posterImage",""));
251-
252251
List<String> parentCollections = (List<String>) response.getOrDefault("parentCollections", new ArrayList<>());
253-
254-
List<Object> orgData = (List<Object>) response.getOrDefault("organisation", Collections.emptyList());
255-
String providerName = extractProviderName(orgData);
256-
252+
String sourceName = sanitizeString((String) response.getOrDefault("sourceName", ""));
257253
Map<String, Object> courseInfoMap = new HashMap<>();
258254
courseInfoMap.put("courseId", courseId);
259255
courseInfoMap.put("courseName", courseName);
260256
courseInfoMap.put("parentCollections", parentCollections);
261257
courseInfoMap.put("primaryCategory", primaryCategory);
262258
courseInfoMap.put("coursePosterImage", posterImage);
263-
courseInfoMap.put("providerName", providerName);
264-
259+
courseInfoMap.put("providerName", sourceName);
265260
return courseInfoMap;
266261
} else {
267262
logger.error("Not able to find the content info for :" + courseId);
@@ -273,17 +268,15 @@ public static Map<String, Object> getCourseInfo(
273268
String primaryCategory = sanitizeString((String) courseMetadata.getOrDefault("primaryCategory", ""));
274269
List<String> parentCollections = (List<String>) courseMetadata.getOrDefault("parentCollections", new ArrayList<>());
275270
String posterImage = sanitizeString((String) courseMetadata.getOrDefault("posterImage", ""));
276-
277-
List<Object> orgData = (List<Object>) courseMetadata.getOrDefault("organisation", Collections.emptyList());
278-
String providerName = extractProviderName(orgData);
271+
String sourceName = sanitizeString((String) courseMetadata.getOrDefault("sourceName", ""));
279272

280273
Map<String, Object> courseInfoMap = new HashMap<>();
281274
courseInfoMap.put("courseId", courseId);
282275
courseInfoMap.put("courseName", courseName);
283276
courseInfoMap.put("parentCollections", parentCollections);
284277
courseInfoMap.put("primaryCategory", primaryCategory);
285278
courseInfoMap.put("coursePosterImage", posterImage);
286-
courseInfoMap.put("providerName", providerName);
279+
courseInfoMap.put("providerName", sourceName);
287280

288281
return courseInfoMap;
289282
}
@@ -298,14 +291,6 @@ private static String sanitizeString(String input) {
298291
.orElse("");
299292
}
300293

301-
private static String extractProviderName(List<Object> orgData) {
302-
if (!orgData.isEmpty()) {
303-
String pm = orgData.get(0).toString();
304-
return pm;
305-
}
306-
return "";
307-
}
308-
309294
public Response fetchEventTemplate(String eventId, String batchId) throws BaseException {
310295
Map<String, Object> primaryKey = new HashMap<>();
311296
primaryKey.put(JsonKeys.EVENT_ID, eventId);

0 commit comments

Comments
 (0)