chore: resolve comments and set params in update migration

Author: mbreithecker

app/upgrades/v2_2/upgrade.go

@@ -4,7 +4,9 @@ import (
 	"context"
 	"fmt"
 
+	"cosmossdk.io/math"
 	liquidkeeper "github.com/KYVENetwork/chain/x/liquid/keeper"
+	liquidtypes "github.com/KYVENetwork/chain/x/liquid/types"
 	stakingKeeper "github.com/cosmos/cosmos-sdk/x/staking/keeper"
 
 	"cosmossdk.io/log"
@@ -33,9 +35,12 @@ func CreateUpgradeHandler(
 
 		// Run cosmos migrations
 		migratedVersionMap, err := mm.RunMigrations(ctx, configurator, fromVM)
+		if err != nil {
+			return nil, err
+		}
 
 		// Run KYVE migrations
-		validators, _ := stakingKeeper.GetValidators(ctx, 1_000)
+		validators, _ := stakingKeeper.GetAllValidators(ctx)
 		for _, v := range validators {
 			valAddress, _ := sdk.ValAddressFromBech32(v.OperatorAddress)
 			err := liquidStakingKeeper.Hooks().AfterValidatorCreated(ctx, valAddress)
@@ -44,6 +49,14 @@ func CreateUpgradeHandler(
 			}
 		}
 
+		err = liquidStakingKeeper.SetParams(ctx, liquidtypes.Params{
+			GlobalLiquidStakingCap:    math.LegacyMustNewDecFromStr("0.25"),
+			ValidatorLiquidStakingCap: math.LegacyMustNewDecFromStr("0.25"),
+		})
+		if err != nil {
+			return nil, err
+		}
+
 		logger.Info(fmt.Sprintf("finished upgrade %v", UpgradeName))
 
 		return migratedVersionMap, err

docs/static/openapi.yml

@@ -9831,7 +9831,7 @@ paths:
                     title: validator delegated to for tokenize share record creation
                 title: TokenizeShareRecord represents a tokenized delegation
             description: |-
-              QueryTokenizeShareRecordByIdRequest is response type for the
+              QueryTokenizeShareRecordByIdResponse is response type for the
               Query/QueryTokenizeShareRecordById RPC method.
         default:
           description: An unexpected error response.
@@ -10060,7 +10060,7 @@ paths:
                 type: string
             description: |-
               QueryTotalLiquidStakedResponse is response type for the
-              Query/QueryQueryTotalLiquidStaked RPC method.
+              Query/QueryTotalLiquidStaked RPC method.
         default:
           description: An unexpected error response.
           schema:

proto/kyve/liquid/v1beta1/liquid.proto

@@ -14,7 +14,7 @@ option go_package = "github.com/KYVENetwork/chain/x/liquid/types";
 
 // Params defines the parameters for the x/liquid module.
 message Params {
-  option (amino.name) = "gaia/x/liquid/Params";
+  option (amino.name) = "kyve/x/liquid/Params";
   option (gogoproto.equal) = true;
 
   // global_liquid_staking_cap represents a cap on the portion of stake that

proto/kyve/liquid/v1beta1/query.proto

@@ -135,7 +135,7 @@ message QueryTokenizeShareRecordByIdRequest {
   uint64 id = 1;
 }
 
-// QueryTokenizeShareRecordByIdRequest is response type for the
+// QueryTokenizeShareRecordByIdResponse is response type for the
 // Query/QueryTokenizeShareRecordById RPC method.
 message QueryTokenizeShareRecordByIdResponse {
   TokenizeShareRecord record = 1 [(gogoproto.nullable) = false];
@@ -205,7 +205,7 @@ message QueryTotalTokenizeSharedAssetsResponse {
 message QueryTotalLiquidStaked {}
 
 // QueryTotalLiquidStakedResponse is response type for the
-// Query/QueryQueryTotalLiquidStaked RPC method.
+// Query/QueryTotalLiquidStaked RPC method.
 message QueryTotalLiquidStakedResponse {
   string tokens = 1;
 }

proto/kyve/liquid/v1beta1/tx.proto

@@ -54,7 +54,7 @@ service Msg {
 // MsgUpdateParams is the Msg/UpdateParams request type.
 message MsgUpdateParams {
   option (cosmos.msg.v1.signer) = "authority";
-  option (amino.name) = "gaia/liquid/MsgUpdateParams";
+  option (amino.name) = "kyve/liquid/MsgUpdateParams";
 
   // authority is the address that controls the module (defaults to x/gov unless
   // overwritten).
@@ -75,7 +75,7 @@ message MsgUpdateParamsResponse {}
 // MsgTokenizeShares tokenizes a delegation
 message MsgTokenizeShares {
   option (cosmos.msg.v1.signer) = "delegator_address";
-  option (amino.name) = "gaia/MsgTokenizeShares";
+  option (amino.name) = "kyve/MsgTokenizeShares";
 
   option (gogoproto.equal) = false;
   option (gogoproto.goproto_getters) = false;

x/liquid/client/cli/tx.go

@@ -1,7 +1,6 @@
 // This file was modified from its original version.
 // Original source: https://github.com/cosmos/gaia/blob/b3583a755ad2947582f8e9c969806b187668ea23/x/liquid/client/cli/tx.go
 // Modifications made by KYVE, 2025.
-// - Changed import paths
 
 package cli
 
@@ -274,7 +273,7 @@ func NewWithdrawAllTokenizeShareRecordRewardCmd(ac address.Codec) *cobra.Command
 		Long: strings.TrimSpace(
 			fmt.Sprintf(`Withdraw reward for all owned TokenizeShareRecord
 Example:
-$ %s tx distribution withdraw-all-tokenize-share-rewards --from mykey
+$ %s tx liquid withdraw-all-tokenize-share-rewards --from mykey
 `,
 				version.AppName,
 			),
@@ -310,7 +309,7 @@ func NewWithdrawTokenizeShareRecordRewardCmd(ac address.Codec) *cobra.Command {
 		Long: strings.TrimSpace(
 			fmt.Sprintf(`Withdraw reward for an owned TokenizeShareRecord
 Example:
-$ %s tx distribution withdraw-tokenize-share-rewards 1 --from mykey
+$ %s tx liquid withdraw-tokenize-share-rewards 1 --from mykey
 `,
 				version.AppName,
 			),