Skip to content

Commit 5073332

Browse files
committed
fix: don't play animation on game over
1 parent a7aa8db commit 5073332

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

kaggle_environments/envs/open_spiel_env/games/go/visualizer/v2/src/components/GameRenderer.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ export default memo(function GameRenderer(options: GameRendererProps<GoStep[]>)
4242
setState(game, options);
4343
}, [options, setState]);
4444

45-
const gameOver = options.replay.steps.at(options.step)?.winner; // game.isOver();
45+
const gameOver = options.replay.steps.at(options.step)?.winner;
4646
// React 18 doesn't support the `inert` HTML attribute as a prop, so we
4747
// set it imperatively via a ref callback. This can be replaced with a
4848
// regular `inert` prop once the project upgrades to React 19+.
@@ -71,7 +71,7 @@ export default memo(function GameRenderer(options: GameRendererProps<GoStep[]>)
7171
</div>
7272
{options.step === 0 && <VersusBanner options={options} />}
7373
{gameOver && <GameOverModal />}
74-
{showHeroAnimations && <HeroAnimationModal />}
74+
{showHeroAnimations && !gameOver && <HeroAnimationModal />}
7575
</main>
7676
);
7777
});

kaggle_environments/envs/open_spiel_env/games/go/visualizer/v2/src/transformers/goTransformer.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,12 +99,14 @@ export const goTransformer = (environment: any): GoStep[] => {
9999
});
100100
}
101101

102+
const lastReplayStep = goReplay.steps[goReplay.steps.length - 1];
103+
102104
goSteps.push({
103105
step: goSteps.length,
104106
players: extraStepPlayers,
105107
boardState: goSteps[goSteps.length - 1].boardState,
106-
isTerminal: goSteps[goSteps.length - 1].isTerminal,
107-
winner: deriveWinner(goReplay.steps[goReplay.steps.length - 1]),
108+
isTerminal: lastReplayStep[0].observation.isTerminal,
109+
winner: deriveWinner(lastReplayStep),
108110
});
109111

110112
return goSteps;

0 commit comments

Comments
 (0)