Allow shed actions from locked shed-access tiles in kaggriculture - #1392
Merged
Conversation
The four shed-access tiles are one per quadrant, and only NW starts unlocked, so three of them begin LOCKED. The LOCKED guard ran before PICKUP/DROP/PLACE, which meant a unit standing on one of those tiles could not use the shed it was standing next to -- including the first hire of each day, whose least-occupied spawn lands on (5,4). Move those three ops above the guard. They only use the tile as a standing position; the shed is not a tile and is never locked. Every op that mutates the standing tile stays below the guard, so PLANT, BUILD_COOP, BUILD_PASTURE, DIG and the rest still no-op on locked ground and consume nothing. PLACE spans both cases. Its animal branch requires a dict tile and a LOCKED tile is the string "LOCKED", so it cannot match there and falls through to the shed path; covered by test rather than changed. Also correct two README lines that claimed all tile actions no-op on locked tiles.
dominoweir
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four shed-access tiles are one per quadrant, and only NW starts unlocked, so three of them begin LOCKED. The LOCKED guard ran before PICKUP/DROP/PLACE, which meant a unit standing on one of those tiles could not use the shed it was standing next to -- including the first hire of each day, whose least-occupied spawn lands on (5,4).
Move those three ops above the guard. They only use the tile as a standing position; the shed is not a tile and is never locked. Every op that mutates the standing tile stays below the guard, so PLANT, BUILD_COOP, BUILD_PASTURE, DIG and the rest still no-op on locked ground and consume nothing.
PLACE spans both cases. Its animal branch requires a dict tile and a LOCKED tile is the string "LOCKED", so it cannot match there and falls through to the shed path; covered by test rather than changed.
Also correct two README lines that claimed all tile actions no-op on locked tiles.