fix: resolve CI failures from spotless, metric count, and branch coverage

- DeferredVersionSwapService.java: wrap long isAbandonedDeferredVersion
  return at the && operator and collapse split childVersion assignment to
  one line (spotlessJavaCheck violations)
- TestDeferredVersionSwapServiceWithSequentialRollout.java: condense
  abandonedParentStatuses() array to match google-java-format style
  (spotlessJavaCheck violation)
- ServerMetricEntityTest: update expected count 185 → 186 to reflect the
  new VERSION_COUNT entry added to StorageEngineOtelMetricEntity
- AsyncMetricEntityStateOneEnumTest / AsyncMetricEntityStateTwoEnumsTest:
  add testCloseUnregistersObservableDoubleGauge and
  testCloseOnDisabledInstanceIsNoOp to cover the two missing branches in
  the new close() method (fixes venice-client-common diffCoverage < 50%)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Author: KaiSernLim

clients/da-vinci-client/src/test/java/com/linkedin/davinci/stats/ServerMetricEntityTest.java

@@ -22,7 +22,7 @@
 public class ServerMetricEntityTest {
   @Test
   public void testServerMetricEntitiesCount() {
-    assertEquals(SERVER_METRIC_ENTITIES.size(), 185, "Expected 185 unique metric entities");
+    assertEquals(SERVER_METRIC_ENTITIES.size(), 186, "Expected 186 unique metric entities");
   }
 
   /**

internal/venice-client-common/src/test/java/com/linkedin/venice/stats/metrics/AsyncMetricEntityStateOneEnumTest.java

@@ -19,6 +19,7 @@
 import com.linkedin.venice.stats.metrics.AsyncMetricResolvers.LiveStateResolverOneEnum;
 import com.linkedin.venice.stats.metrics.AsyncMetricResolvers.ValueResolverOneEnum;
 import io.opentelemetry.api.common.Attributes;
+import io.opentelemetry.api.metrics.ObservableDoubleGauge;
 import io.opentelemetry.api.metrics.ObservableDoubleMeasurement;
 import io.opentelemetry.api.metrics.ObservableLongGauge;
 import io.opentelemetry.api.metrics.ObservableLongMeasurement;
@@ -102,9 +103,40 @@ public void testCloseUnregistersObservableGauge() {
     verify(gauge).close();
   }
 
+  @Test
+  public void testCloseUnregistersObservableDoubleGauge() {
+    when(mockMetricEntity.getMetricType()).thenReturn(MetricType.ASYNC_DOUBLE_GAUGE);
+    ObservableDoubleGauge gauge = mock(ObservableDoubleGauge.class);
+    when(mockOtelRepository.registerObservableDoubleGauge(eq(mockMetricEntity), any())).thenReturn(gauge);
+    AsyncMetricEntityStateOneEnum<DimensionEnum1> metricState = AsyncMetricEntityStateOneEnum.create(
+        mockMetricEntity,
+        mockOtelRepository,
+        baseDimensionsMap,
+        DimensionEnum1.class,
+        e -> e,
+        (state, e) -> 1L);
+
+    metricState.close();
+
+    verify(gauge).close();
+  }
+
+  @Test
+  public void testCloseOnDisabledInstanceIsNoOp() {
+    AsyncMetricEntityStateOneEnum<DimensionEnum1> metricState = AsyncMetricEntityStateOneEnum.create(
+        mockMetricEntity,
+        null /* OTel disabled */,
+        baseDimensionsMap,
+        DimensionEnum1.class,
+        e -> e,
+        (state, e) -> 1L);
+
+    // Must not throw when instrument is null.
+    metricState.close();
+  }
+
   @Test
   public void testCallbackEmitsOnlyWhenLiveStateResolverReturnsNonNull() {
-    // liveStateResolver returns state for DIMENSION_ONE only; DIMENSION_TWO is dormant.
     LiveStateResolverOneEnum<DimensionEnum1, Object> liveStateResolver =
         e -> e == DimensionEnum1.DIMENSION_ONE ? "live" : null;
     ValueResolverOneEnum<Object, DimensionEnum1> valueResolver = (state, e) -> 42L;

internal/venice-client-common/src/test/java/com/linkedin/venice/stats/metrics/AsyncMetricEntityStateTwoEnumsTest.java

@@ -20,6 +20,7 @@
 import com.linkedin.venice.stats.metrics.AsyncMetricResolvers.LiveStateResolverTwoEnums;
 import com.linkedin.venice.stats.metrics.AsyncMetricResolvers.ValueResolverTwoEnums;
 import io.opentelemetry.api.common.Attributes;
+import io.opentelemetry.api.metrics.ObservableDoubleGauge;
 import io.opentelemetry.api.metrics.ObservableDoubleMeasurement;
 import io.opentelemetry.api.metrics.ObservableLongGauge;
 import io.opentelemetry.api.metrics.ObservableLongMeasurement;
@@ -113,6 +114,40 @@ public void testCloseUnregistersObservableGauge() {
     verify(gauge).close();
   }
 
+  @Test
+  public void testCloseUnregistersObservableDoubleGauge() {
+    when(mockMetricEntity.getMetricType()).thenReturn(MetricType.ASYNC_DOUBLE_GAUGE);
+    ObservableDoubleGauge gauge = mock(ObservableDoubleGauge.class);
+    when(mockOtelRepository.registerObservableDoubleGauge(eq(mockMetricEntity), any())).thenReturn(gauge);
+    AsyncMetricEntityStateTwoEnums<DimensionEnum1, DimensionEnum2> metricState = AsyncMetricEntityStateTwoEnums.create(
+        mockMetricEntity,
+        mockOtelRepository,
+        baseDimensionsMap,
+        DimensionEnum1.class,
+        DimensionEnum2.class,
+        (e1, e2) -> e1,
+        (state, e1, e2) -> 1L);
+
+    metricState.close();
+
+    verify(gauge).close();
+  }
+
+  @Test
+  public void testCloseOnDisabledInstanceIsNoOp() {
+    AsyncMetricEntityStateTwoEnums<DimensionEnum1, DimensionEnum2> metricState = AsyncMetricEntityStateTwoEnums.create(
+        mockMetricEntity,
+        null /* OTel disabled */,
+        baseDimensionsMap,
+        DimensionEnum1.class,
+        DimensionEnum2.class,
+        (e1, e2) -> e1,
+        (state, e1, e2) -> 1L);
+
+    // Must not throw when instrument is null.
+    metricState.close();
+  }
+
   @Test
   public void testCallbackEmitsOnlyWhenLiveStateResolverReturnsNonNull() {
     LiveStateResolverTwoEnums<DimensionEnum1, DimensionEnum2, Object> liveStateResolver = (e1, e2) -> {

services/venice-controller/src/main/java/com/linkedin/venice/controller/DeferredVersionSwapService.java

@@ -971,7 +971,8 @@ private static String getVersionProcessingKey(String clusterName, String storeNa
   }
 
   private static boolean isAbandonedDeferredVersion(Version version) {
-    return version != null && version.isVersionSwapDeferred() && ABANDONED_VERSION_STATUSES.contains(version.getStatus());
+    return version != null && version.isVersionSwapDeferred()
+        && ABANDONED_VERSION_STATUSES.contains(version.getStatus());
   }
 
   private void submitTerminalVersionReconciliationTasks(
@@ -1393,8 +1394,7 @@ private boolean reconcileAbandonedVersionInChildRegions(
       }
 
       StoreInfo childStore = storeResponse.getStore();
-      Version childVersion =
-          getVersionFromStoreInRegion(region, storeName, targetVersionNum, storeResponse);
+      Version childVersion = getVersionFromStoreInRegion(region, storeName, targetVersionNum, storeResponse);
       if (childVersion == null) {
         allRegionsTerminal = false;
         continue;

services/venice-controller/src/test/java/com/linkedin/venice/controller/TestDeferredVersionSwapServiceWithSequentialRollout.java

@@ -593,9 +593,7 @@ public void testSequentialRolloutPostSwapValidationRollbackMarksNonTargetRegions
 
   @DataProvider(name = "abandonedParentStatuses")
   public Object[][] abandonedParentStatuses() {
-    return new Object[][] {
-        { VersionStatus.ERROR },
-        { VersionStatus.PARTIALLY_ONLINE },
+    return new Object[][] { { VersionStatus.ERROR }, { VersionStatus.PARTIALLY_ONLINE },
         { VersionStatus.ROLLED_BACK } };
   }