QTermWidget "share" not copy over Build

[eduardomozart]

Describe the bug
The Linux build scripts copy the files of QTermWidget manually to the "share" folder:

RabbitRemoteControl/Script/build_appimage.sh

Line 194 in 2302429

cp -r ${INSTALL_DIR}/share/qtermwidget6 ${INSTALL_APP_DIR}/share/

I believe it should be moved to CMake, since macOS also requires those files, otherwise the "Key binding" and "Color scheme" options isn't available on Preferences > Terminal and consequently some keys (like backspace/delete) do not work on Terminal for macOS.
For macOS, after compiling, it requires manually copying the [qtermwidget installation path]/share/qtermwidget6 folder to /RabbitRemoteControl.App/Contents/share/qtermwidget6 folder. Also, if the user starts the program without those files in place, the Rabbit Remote Control configuration file ~/Documents/Rabbit/RabbitRemoteControl/RabbitRemoteControl.conf set keybinding values as empty, not allowing the user to select any value on UI, so I had to delete those files to allow it to be recreated so I was able to select a keybinding even after copying the qtermwidget share files over.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Preferences'
2. Click on 'Terminal'
3. See error (Color scheme and Key binding empty and unable to choose any).

Expected behavior
QTermWidget share files should be copied over so Color scheme and Key binding options are available for selection.

Screenshots
After adding the QTermWidget share files, the Color scheme and Key binding options are available for selection as shown below:

Application details

• The application version (Open applicatoin → help → about)
• Compile date (Open applicatoin → help → about)
• Log file

Qt
Version: 6.9.2

System information

Desktop (please complete the following information):

• OS: macOS
• Version: Sequoia (15.6.1)

Smartphone (please complete the following information):

• Device: [e.g. Android/iPhone6/...]
• OS: [e.g. iOS8.1]
• Version [e.g. 22]

Additional context
None.

[KangLin]

In the official code, resource access is hardcoded into the build directory：
See: https://github.com/lxqt/qtermwidget/blob/1fea00cfc13e67ccc3be506263d0c0cc6fe22a19/lib/tools.cpp#L14

Because this is a third-party source code, I think it would be better to handle it in the build script, but I should explain this in the compilation documentation.

[eduardomozart]

Hello,
Sorry, I'm not a C programmer, so I think I said it wrong. It would be great if, when compiling using Qt Creator, those files are copied over, because otherwise, the Terminal does not work as expected. I believe it's handled during the build instead, as those are already compiled files.

It seems that you intended in the past to add the path directly, as can be seen in:

RabbitRemoteControl/Src/Terminal/OperateTerminal.cpp

Lines 43 to 49 in 2302429

	/*QTermWidget::addCustomKeyboardLayoutDir(QApplication::applicationDirPath()
	+ QDir::separator() + "kb-layouts");
	QTermWidget::addCustomKeyboardLayoutDir(QApplication::applicationDirPath()
	+ QDir::separator() + ".."
	+ QDir::separator() + "share"
	+ QDir::separator() + "qtermwidget6"
	+ QDir::separator() + "kb-layouts");//*/

But even with those lines commented out, when the [qtermwidget installation path]/share/qtermwidget6 folder is copied over to /RabbitRemoteControl.App/Contents/share/qtermwidget6 folder, the macOS keybindings work as expected, so I believe this path is already part of get_kb_layout_dir, which's why it works when that path exists.

[KangLin]

when compiling using Qt Creator, those files are copied over, because otherwise, the Terminal does not work as expected. I believe it's handled during the build instead, as those are already compiled files.

Since the build-time install directory for these resources is hard-coded into the library, it should work fine as long as you don't move it.

[eduardomozart]

I see. I do believe that if I install the qTermWidget in my machine, it should work as expected (I didn't install it machine-wide, only in a path that I manually specified in CMake), but as Qt, it would be great if it's bundled with the .app instead of relying on user compiling installing it on it's own before running the program.

[KangLin]

@tsujan

Can you solve it?

[tsujan]

Sorry, macOS is outside my work area.

Making a PR at QTermWidget would be very appreciated if you've found a solution (please also describe the problem in your PR's comment). It should be reviewed by a dev who is familiar with macOS. Also, I think it could be merged if at least another macOS user confirms that it works fine.

In case you haven't found a solution, you could open an issue at https://github.com/lxqt/qtermwidget/issues.