Skip to content

Commit e439aa2

Browse files
committed
test(quality): replace assertIsString with assertSame in all testGetName() methods
All getName() assertions now validate the actual string value instead of just the type, following ARFA 1.3 Spec V4.0 testing standards. Files updated (7 consolidated test files): - BrazilianRulesTest: CpfToDigits, CnpjToDigits, CepToDigits, PhoneFormat - DataRulesTest: CsvToArray, JsonEncode, Implode - DateRulesTest: DateToIso8601, RelativeDate - EncodingRulesTest: Base64Encode, Base64Decode - NumericRulesTest: CurrencyFormat - StringRulesTest: CamelCase, SnakeCase, KebabCase, PascalCase, Mask, Reverse, Repeat - StructureRulesTest: Flatten, Pluck, GroupBy, RenameKeys, Unflatten
1 parent a007f8e commit e439aa2

7 files changed

Lines changed: 25 additions & 25 deletions

File tree

tests/Unit/Rule/Brazilian/BrazilianRulesTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,9 @@ public function testNonStringPassthrough(): void
7171
#[Test]
7272
public function testGetName(): void
7373
{
74-
$this->assertIsString(new CpfToDigitsRule()->getName());
75-
$this->assertIsString(new CnpjToDigitsRule()->getName());
76-
$this->assertIsString((new \KaririCode\Transformer\Rule\Brazilian\CepToDigitsRule())->getName());
77-
$this->assertIsString((new \KaririCode\Transformer\Rule\Brazilian\PhoneFormatRule())->getName());
74+
$this->assertSame('brazilian.cpf_to_digits', (new CpfToDigitsRule())->getName());
75+
$this->assertSame('brazilian.cnpj_to_digits', (new CnpjToDigitsRule())->getName());
76+
$this->assertSame('brazilian.cep_to_digits', (new CepToDigitsRule())->getName());
77+
$this->assertSame('brazilian.phone_format', (new PhoneFormatRule())->getName());
7878
}
7979
}

tests/Unit/Rule/Data/DataRulesTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,8 @@ public function testImplode(): void
7777
#[Test]
7878
public function testGetName(): void
7979
{
80-
$this->assertIsString((new \KaririCode\Transformer\Rule\Data\CsvToArrayRule())->getName());
81-
$this->assertIsString((new \KaririCode\Transformer\Rule\Data\JsonEncodeRule())->getName());
82-
$this->assertIsString((new \KaririCode\Transformer\Rule\Data\ImplodeRule())->getName());
80+
$this->assertSame('data.csv_to_array', (new CsvToArrayRule())->getName());
81+
$this->assertSame('data.json_encode', (new JsonEncodeRule())->getName());
82+
$this->assertSame('data.implode', (new ImplodeRule())->getName());
8383
}
8484
}

tests/Unit/Rule/Date/DateRulesTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ public function testRelativeDateUsesDefaultNow(): void
163163
#[Test]
164164
public function testGetName(): void
165165
{
166-
$this->assertIsString((new \KaririCode\Transformer\Rule\Date\DateToIso8601Rule())->getName());
167-
$this->assertIsString((new \KaririCode\Transformer\Rule\Date\RelativeDateRule())->getName());
166+
$this->assertSame('date.to_iso8601', (new DateToIso8601Rule())->getName());
167+
$this->assertSame('date.relative', (new RelativeDateRule())->getName());
168168
}
169169
}

tests/Unit/Rule/Encoding/EncodingRulesTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,8 @@ public function testNonStringPassthrough(): void
6262
#[Test]
6363
public function testGetName(): void
6464
{
65-
$this->assertIsString((new \KaririCode\Transformer\Rule\Encoding\Base64EncodeRule())->getName());
66-
$this->assertIsString((new \KaririCode\Transformer\Rule\Encoding\Base64DecodeRule())->getName());
67-
$this->assertIsString(new HashRule()->getName());
65+
$this->assertSame('encoding.base64_encode', (new Base64EncodeRule())->getName());
66+
$this->assertSame('encoding.base64_decode', (new Base64DecodeRule())->getName());
67+
$this->assertSame('encoding.hash', (new HashRule())->getName());
6868
}
6969
}

tests/Unit/Rule/Numeric/NumericRulesTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,6 @@ public function testNumberToWords(): void
6767
#[Test]
6868
public function testGetName(): void
6969
{
70-
$this->assertIsString((new \KaririCode\Transformer\Rule\Numeric\CurrencyFormatRule())->getName());
70+
$this->assertSame('numeric.currency_format', (new CurrencyFormatRule())->getName());
7171
}
7272
}

tests/Unit/Rule/String/StringRulesTest.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,12 +88,12 @@ public function testRepeat(): void
8888
public function testGetName(): void
8989
{
9090
// String rules
91-
$this->assertIsString((new \KaririCode\Transformer\Rule\String\CamelCaseRule())->getName());
92-
$this->assertIsString((new \KaririCode\Transformer\Rule\String\SnakeCaseRule())->getName());
93-
$this->assertIsString((new \KaririCode\Transformer\Rule\String\KebabCaseRule())->getName());
94-
$this->assertIsString((new \KaririCode\Transformer\Rule\String\PascalCaseRule())->getName());
95-
$this->assertIsString((new \KaririCode\Transformer\Rule\String\MaskRule())->getName());
96-
$this->assertIsString((new \KaririCode\Transformer\Rule\String\ReverseRule())->getName());
97-
$this->assertIsString((new \KaririCode\Transformer\Rule\String\RepeatRule())->getName());
91+
$this->assertSame('string.camel_case', (new CamelCaseRule())->getName());
92+
$this->assertSame('string.snake_case', (new SnakeCaseRule())->getName());
93+
$this->assertSame('string.kebab_case', (new KebabCaseRule())->getName());
94+
$this->assertSame('string.pascal_case', (new PascalCaseRule())->getName());
95+
$this->assertSame('string.mask', (new MaskRule())->getName());
96+
$this->assertSame('string.reverse', (new ReverseRule())->getName());
97+
$this->assertSame('string.repeat', (new RepeatRule())->getName());
9898
}
9999
}

tests/Unit/Rule/Structure/StructureRulesTest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,10 @@ public function testRenameKeys(): void
8989
#[Test]
9090
public function testGetName(): void
9191
{
92-
$this->assertIsString((new \KaririCode\Transformer\Rule\Structure\FlattenRule())->getName());
93-
$this->assertIsString((new \KaririCode\Transformer\Rule\Structure\PluckRule())->getName());
94-
$this->assertIsString((new \KaririCode\Transformer\Rule\Structure\GroupByRule())->getName());
95-
$this->assertIsString((new \KaririCode\Transformer\Rule\Structure\RenameKeysRule())->getName());
96-
$this->assertIsString((new \KaririCode\Transformer\Rule\Structure\UnflattenRule())->getName());
92+
$this->assertSame('structure.flatten', (new FlattenRule())->getName());
93+
$this->assertSame('structure.pluck', (new PluckRule())->getName());
94+
$this->assertSame('structure.group_by', (new GroupByRule())->getName());
95+
$this->assertSame('structure.rename_keys', (new RenameKeysRule())->getName());
96+
$this->assertSame('structure.unflatten', (new UnflattenRule())->getName());
9797
}
9898
}

0 commit comments

Comments
 (0)